Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/common/extensions/extension_message_bundle.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_l10n_util.h ('k') | chrome/common/extensions/extension_permission_set.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_message_bundle.h
===================================================================
--- chrome/common/extensions/extension_message_bundle.h (revision 92173)
+++ chrome/common/extensions/extension_message_bundle.h (working copy)
@@ -12,14 +12,16 @@
#include "base/memory/linked_ptr.h"
+namespace base {
class DictionaryValue;
+}
// Contains localized extension messages for one locale. Any messages that the
// locale does not provide are pulled from the default locale.
class ExtensionMessageBundle {
public:
typedef std::map<std::string, std::string> SubstitutionMap;
- typedef std::vector<linked_ptr<DictionaryValue> > CatalogVector;
+ typedef std::vector<linked_ptr<base::DictionaryValue> > CatalogVector;
// JSON keys of interest for messages file.
static const char* kContentKey;
@@ -123,12 +125,12 @@
// They replace all $PLACEHOLDERS$ with their value, and return just key/value
// of the message.
bool GetMessageValue(const std::string& key,
- const DictionaryValue& catalog,
+ const base::DictionaryValue& catalog,
std::string* value,
std::string* error) const;
// Get all placeholders for a given message from JSON subtree.
- bool GetPlaceholders(const DictionaryValue& name_tree,
+ bool GetPlaceholders(const base::DictionaryValue& name_tree,
const std::string& name_key,
SubstitutionMap* placeholders,
std::string* error) const;
« no previous file with comments | « chrome/common/extensions/extension_l10n_util.h ('k') | chrome/common/extensions/extension_permission_set.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698