Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: chrome/browser/extensions/extension_preference_api.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_pref_value_map.h ('k') | chrome/browser/extensions/extension_prefs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_preference_api.h
===================================================================
--- chrome/browser/extensions/extension_preference_api.h (revision 92173)
+++ chrome/browser/extensions/extension_preference_api.h (working copy)
@@ -12,6 +12,10 @@
#include "chrome/browser/prefs/pref_change_registrar.h"
#include "content/common/notification_observer.h"
+namespace base {
+class Value;
+}
+
class ExtensionPreferenceEventRouter : public NotificationObserver {
public:
explicit ExtensionPreferenceEventRouter(Profile* profile);
@@ -39,8 +43,6 @@
DISALLOW_COPY_AND_ASSIGN(ExtensionPreferenceEventRouter);
};
-class Value;
-
class PrefTransformerInterface {
public:
virtual ~PrefTransformerInterface() {}
@@ -51,15 +53,17 @@
// |error| and returns NULL otherwise. |bad_message| is passed to simulate
// the behavior of EXTENSION_FUNCTION_VALIDATE. It is never NULL.
// The ownership of the returned value is passed to the caller.
- virtual Value* ExtensionToBrowserPref(const Value* extension_pref,
- std::string* error,
- bool* bad_message) = 0;
+ virtual base::Value* ExtensionToBrowserPref(
+ const base::Value* extension_pref,
+ std::string* error,
+ bool* bad_message) = 0;
// Converts the representation of the preference as stored in the browser
// into a representation that is used by the extension.
// Returns the extension representation in case of success or NULL otherwise.
// The ownership of the returned value is passed to the caller.
- virtual Value* BrowserToExtensionPref(const Value* browser_pref) = 0;
+ virtual base::Value* BrowserToExtensionPref(
+ const base::Value* browser_pref) = 0;
};
class GetPreferenceFunction : public SyncExtensionFunction {
« no previous file with comments | « chrome/browser/extensions/extension_pref_value_map.h ('k') | chrome/browser/extensions/extension_prefs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698