Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: content/browser/debugger/extension_ports_remote_service.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/debugger/devtools_window.h ('k') | content/browser/font_list_async.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/debugger/extension_ports_remote_service.h
===================================================================
--- content/browser/debugger/extension_ports_remote_service.h (revision 92173)
+++ content/browser/debugger/extension_ports_remote_service.h (working copy)
@@ -21,10 +21,13 @@
class DevToolsProtocolHandler;
class DevToolsRemoteMessage;
+class GURL;
+
+namespace base {
class DictionaryValue;
-class GURL;
class ListValue;
class Value;
+}
class ExtensionPortsRemoteService : public DevToolsRemoteListener,
public IPC::Message::Sender {
@@ -70,14 +73,14 @@
// Sends a JSON message with the |response| to the external client.
// |tool| and |destination| are used as the respective header values.
- void SendResponse(const Value& response,
+ void SendResponse(const base::Value& response,
const std::string& tool,
const std::string& destination);
// Handles a message from the ExtensionMessageService.
void OnExtensionMessageInvoke(const std::string& extension_id,
const std::string& function_name,
- const ListValue& args,
+ const base::ListValue& args,
const GURL& event_url);
// Handles a message sent from an extension through the
// ExtensionMessageService, to be passed to the external client.
@@ -87,12 +90,14 @@
// Implementation for the commands we can receive from the external client.
// Opens a channel to an extension.
- void ConnectCommand(DictionaryValue* content, DictionaryValue* response);
+ void ConnectCommand(base::DictionaryValue* content,
+ base::DictionaryValue* response);
// Disconnects a message port.
- void DisconnectCommand(int port_id, DictionaryValue* response);
+ void DisconnectCommand(int port_id, base::DictionaryValue* response);
// Sends a message to an extension through an established message port.
- void PostMessageCommand(int port_id, DictionaryValue* content,
- DictionaryValue* response);
+ void PostMessageCommand(int port_id,
+ base::DictionaryValue* content,
+ base::DictionaryValue* response);
// The delegate is used to send responses and events back to the
// external client, and to resolve tab IDs.
« no previous file with comments | « content/browser/debugger/devtools_window.h ('k') | content/browser/font_list_async.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698