Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/extensions/extension_tts_api_controller.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tts_api_controller.h
===================================================================
--- chrome/browser/extensions/extension_tts_api_controller.h (revision 92173)
+++ chrome/browser/extensions/extension_tts_api_controller.h (working copy)
@@ -13,14 +13,16 @@
#include "base/scoped_ptr.h"
#include "googleurl/src/gurl.h"
-class DictionaryValue;
class Extension;
class ExtensionTtsPlatformImpl;
+class Profile;
+
+namespace base {
+class DictionaryValue;
class ListValue;
-class Profile;
class Value;
+}
-
// Events sent back from the TTS engine indicating the progress.
enum TtsEventType {
TTS_EVENT_START,
@@ -67,8 +69,8 @@
void set_text(const std::string& text) { text_ = text; }
const std::string& text() const { return text_; }
- void set_options(const Value* options);
- const Value* options() const { return options_.get(); }
+ void set_options(const base::Value* options);
+ const base::Value* options() const { return options_.get(); }
void set_src_extension_id(const std::string& src_extension_id) {
src_extension_id_ = src_extension_id;
@@ -151,7 +153,7 @@
// The full options arg passed to tts.speak, which may include fields
// other than the ones we explicitly parse, below.
- scoped_ptr<Value> options_;
+ scoped_ptr<base::Value> options_;
// The extension ID of the extension that called speak() and should
// receive events.
@@ -212,7 +214,7 @@
// Return a list of all available voices, including the native voice,
// if supported, and all voices registered by extensions.
- ListValue* GetVoices(Profile* profile);
+ base::ListValue* GetVoices(Profile* profile);
// For unit testing.
void SetPlatformImpl(ExtensionTtsPlatformImpl* platform_impl);
« no previous file with comments | « chrome/browser/extensions/extension_tabs_module.h ('k') | chrome/browser/extensions/extension_tts_engine_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698