Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Unified Diff: chrome/browser/extensions/extension_tabs_module.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module.h
===================================================================
--- chrome/browser/extensions/extension_tabs_module.h (revision 92173)
+++ chrome/browser/extensions/extension_tabs_module.h (working copy)
@@ -15,28 +15,31 @@
class BackingStore;
class Browser;
-class DictionaryValue;
-class ListValue;
class SkBitmap;
class TabContents;
class TabContentsWrapper;
class TabStripModel;
+namespace base {
+class DictionaryValue;
+class ListValue;
+}
+
namespace ExtensionTabUtil {
int GetWindowId(const Browser* browser);
int GetTabId(const TabContents* tab_contents);
std::string GetTabStatusText(bool is_loading);
int GetWindowIdOfTab(const TabContents* tab_contents);
-ListValue* CreateTabList(const Browser* browser);
-DictionaryValue* CreateTabValue(const TabContents* tab_contents);
-DictionaryValue* CreateTabValue(const TabContents* tab_contents,
- TabStripModel* tab_strip,
- int tab_index);
+base::ListValue* CreateTabList(const Browser* browser);
+base::DictionaryValue* CreateTabValue(const TabContents* tab_contents);
+base::DictionaryValue* CreateTabValue(const TabContents* tab_contents,
+ TabStripModel* tab_strip,
+ int tab_index);
// Create a tab value, overriding its kSelectedKey to the provided boolean.
-DictionaryValue* CreateTabValueActive(const TabContents* tab_contents,
- bool active);
-DictionaryValue* CreateWindowValue(const Browser* browser,
- bool populate_tabs);
+base::DictionaryValue* CreateTabValueActive(const TabContents* tab_contents,
+ bool active);
+base::DictionaryValue* CreateWindowValue(const Browser* browser,
+ bool populate_tabs);
// Gets the |tab_strip_model| and |tab_index| for the given |tab_contents|.
bool GetTabStripModel(const TabContents* tab_contents,
TabStripModel** tab_strip_model,
« no previous file with comments | « chrome/browser/extensions/extension_sidebar_api.h ('k') | chrome/browser/extensions/extension_tts_api_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698