Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3953)

Unified Diff: chrome/browser/automation/automation_provider_json.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/automation_provider_json.h
===================================================================
--- chrome/browser/automation/automation_provider_json.h (revision 92173)
+++ chrome/browser/automation/automation_provider_json.h (working copy)
@@ -14,9 +14,12 @@
class AutomationProvider;
class Browser;
+class TabContents;
+
+namespace base {
class DictionaryValue;
-class TabContents;
class Value;
+}
namespace IPC {
class Message;
@@ -35,7 +38,7 @@
// Send a success reply along with data contained in |value|.
// An empty message will be sent if |value| is NULL.
- void SendSuccess(const Value* value);
+ void SendSuccess(const base::Value* value);
// Send an error reply along with error message |error_message|.
void SendError(const std::string& error_message);
@@ -48,7 +51,7 @@
// Gets the browser specified by the given dictionary |args|. |args| should
// contain a key 'windex' which refers to the index of the browser. Returns
// true on success and sets |browser|. Otherwise, |error| will be set.
-bool GetBrowserFromJSONArgs(DictionaryValue* args,
+bool GetBrowserFromJSONArgs(base::DictionaryValue* args,
Browser** browser,
std::string* error) WARN_UNUSED_RESULT;
@@ -56,7 +59,7 @@
// contain a key 'windex' which refers to the index of the parent browser,
// and a key 'tab_index' which refers to the index of the tab in that browser.
// Returns true on success and sets |tab|. Otherwise, |error| will be set.
-bool GetTabFromJSONArgs(DictionaryValue* args,
+bool GetTabFromJSONArgs(base::DictionaryValue* args,
TabContents** tab,
std::string* error) WARN_UNUSED_RESULT;
@@ -65,7 +68,7 @@
// a key 'tab_index' which refers to the index of the tab in that browser.
// Returns true on success and sets |browser| and |tab|. Otherwise, |error|
// will be set.
-bool GetBrowserAndTabFromJSONArgs(DictionaryValue* args,
+bool GetBrowserAndTabFromJSONArgs(base::DictionaryValue* args,
Browser** browser,
TabContents** tab,
std::string* error) WARN_UNUSED_RESULT;
« no previous file with comments | « chrome/browser/automation/automation_provider.h ('k') | chrome/browser/automation/automation_provider_observers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698