Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4478)

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker.h

Issue 7259019: Move base/values.h into the base namespace. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/sandboxed_extension_unpacker.h
===================================================================
--- chrome/browser/extensions/sandboxed_extension_unpacker.h (revision 92173)
+++ chrome/browser/extensions/sandboxed_extension_unpacker.h (working copy)
@@ -13,10 +13,13 @@
#include "base/scoped_temp_dir.h"
#include "content/browser/utility_process_host.h"
-class DictionaryValue;
class Extension;
class ResourceDispatcherHost;
+namespace base {
+class DictionaryValue;
+}
+
class SandboxedExtensionUnpackerClient
: public base::RefCountedThreadSafe<SandboxedExtensionUnpackerClient> {
public:
@@ -32,7 +35,7 @@
// for deleting this memory.
virtual void OnUnpackSuccess(const FilePath& temp_dir,
const FilePath& extension_root,
- const DictionaryValue* original_manifest,
+ const base::DictionaryValue* original_manifest,
const Extension* extension) = 0;
virtual void OnUnpackFailure(const std::string& error) = 0;
@@ -192,15 +195,16 @@
virtual void OnProcessCrashed(int exit_code);
// IPC message handlers.
- void OnUnpackExtensionSucceeded(const DictionaryValue& manifest);
+ void OnUnpackExtensionSucceeded(const base::DictionaryValue& manifest);
void OnUnpackExtensionFailed(const std::string& error_message);
void ReportFailure(FailureReason reason, const std::string& message);
- void ReportSuccess(const DictionaryValue& original_manifest);
+ void ReportSuccess(const base::DictionaryValue& original_manifest);
// Overwrites original manifest with safe result from utility process.
// Returns NULL on error. Caller owns the returned object.
- DictionaryValue* RewriteManifestFile(const DictionaryValue& manifest);
+ base::DictionaryValue* RewriteManifestFile(
+ const base::DictionaryValue& manifest);
// Overwrites original files with safe results from utility process.
// Reports error and returns false if it fails.

Powered by Google App Engine
This is Rietveld 408576698