Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 525019: Revert 35500 - Added an application framework for demos. Ported hellotriangle... (Closed)

Created:
10 years, 11 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
alokp
CC:
chromium-reviews_googlegroups.com, apatrick_chromium
Visibility:
Public.

Description

Revert 35500 - Added an application framework for demos. Ported hellotriangle example in OpenGL ES book to use the application framework. BUG=26099 TEST=Try running hello_triangle executable, you should see a red triangle. Review URL: http://codereview.chromium.org/465051 TBR=alokp@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+536 lines, -706 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D gpu/demos/app_framework/application.h View 1 chunk +0 lines, -57 lines 0 comments Download
D gpu/demos/app_framework/application.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D gpu/demos/app_framework/gles2_utils.h View 1 chunk +0 lines, -27 lines 0 comments Download
D gpu/demos/app_framework/gles2_utils.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D gpu/demos/app_framework/platform.h View 1 chunk +0 lines, -23 lines 0 comments Download
D gpu/demos/demos.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
D gpu/demos/hello_triangle/main.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/gles_book_examples/Chapter_2/Hello_Triangle/Hello_Triangle.h View 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/gles_book_examples/Chapter_2/Hello_Triangle/Hello_Triangle.c View 1 chunk +194 lines, -109 lines 0 comments Download
M third_party/gles_book_examples/Common/Include/esUtil.h View 12 chunks +109 lines, -26 lines 0 comments Download
M third_party/gles_book_examples/Common/Include/esUtil_win.h View 2 chunks +35 lines, -3 lines 0 comments Download
M third_party/gles_book_examples/Common/Source/Win32/esUtil_TGA.c View 1 chunk +0 lines, -3 lines 0 comments Download
A + third_party/gles_book_examples/Common/Source/Win32/esUtil_win32.c View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/gles_book_examples/Common/Source/esShader.c View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/gles_book_examples/Common/Source/esShapes.c View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/gles_book_examples/Common/Source/esTransform.c View 9 chunks +17 lines, -9 lines 0 comments Download
M third_party/gles_book_examples/Common/Source/esUtil.c View 4 chunks +176 lines, -8 lines 0 comments Download
D third_party/gles_book_examples/gles_book_examples.gyp View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Robert Sesek
10 years, 11 months ago (2010-01-05 02:05:19 UTC) #1
Robert Sesek
This brok check deps. It should be an easy fix. http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20(dbg)(1)/builds/17394/steps/check%20deps/logs/stdio
10 years, 11 months ago (2010-01-05 02:06:28 UTC) #2
apatrick
Alok, The fix is to add / modify the DEPS files in the directories check_deps ...
10 years, 11 months ago (2010-01-05 02:19:21 UTC) #3
alokp
LGTM Sorry about that, but I do not understand how it broke the build. Is ...
10 years, 11 months ago (2010-01-05 02:20:37 UTC) #4
Robert Sesek
10 years, 11 months ago (2010-01-05 02:27:55 UTC) #5
On 2010/01/05 02:20:37, alokp wrote:
> LGTM
> 
> Sorry about that, but I do not understand how it broke the build. Is it
because
> of the way third_party file is included?

You just need to modify the appropriate DEPS file to include
"+third_party/gles_book_examples". This allows files in the same directory (and
below) as the DEPS file to include files from third_party/gles_book_examples.

Powered by Google App Engine
This is Rietveld 408576698