Refactors animation to allow for cleaner subclassing. I'm doing this

Refactors animation to allow for cleaner subclassing. I'm doing this
for creating a different animation subclass (which you'll see
shortly).

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46433

[Jay Civelli, 2010-05-04 20:58:07]

LGTM

http://codereview.chromium.org/1961001/diff/2002/5001
File app/animation.cc (right):

http://codereview.chromium.org/1961001/diff/2002/5001#newcode17
app/animation.cc:17: delegate_(NULL) {
Should we initialized start_time_ just to be safe?

http://codereview.chromium.org/1961001/diff/2002/5008
File app/linear_animation.cc (right):

http://codereview.chromium.org/1961001/diff/2002/5008#newcode80
app/linear_animation.cc:80: if (in_end_) {
Nit: if (!in_end)
       return;
     would be simpler.

http://codereview.chromium.org/1961001/diff/2002/5014
File app/tween.cc (right):

http://codereview.chromium.org/1961001/diff/2002/5014#newcode73
app/tween.cc:73: const gfx::Rect& start_bounds,
Indent is wrong.

[sky, 2010-05-04 23:02:05]

http://codereview.chromium.org/1961001/diff/2002/5001
File app/animation.cc (right):

http://codereview.chromium.org/1961001/diff/2002/5001#newcode17
app/animation.cc:17: delegate_(NULL) {
On 2010/05/04 20:58:07, Jay Civelli wrote:
> Should we initialized start_time_ just to be safe?

TimeTicks initializes it to 0 for me, which is fine.

http://codereview.chromium.org/1961001/diff/2002/5008
File app/linear_animation.cc (right):

http://codereview.chromium.org/1961001/diff/2002/5008#newcode80
app/linear_animation.cc:80: if (in_end_) {
On 2010/05/04 20:58:07, Jay Civelli wrote:
> Nit: if (!in_end)
>        return;
>      would be simpler.
>      

Done.

http://codereview.chromium.org/1961001/diff/2002/5014
File app/tween.cc (right):

http://codereview.chromium.org/1961001/diff/2002/5014#newcode73
app/tween.cc:73: const gfx::Rect& start_bounds,
On 2010/05/04 20:58:07, Jay Civelli wrote:
> Indent is wrong.

Done.