Refactors animation to allow for cleaner subclassing. I'm doing this

chrome/browser/views/download_item_view.cc

-// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/download_item_view.h"
 
 #include <vector>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "app/text_elider.h"
@@ skipping 341 matching lines @@
       download_->is_paused() ? StopDownloadProgress() : StartDownloadProgress();
       break;
     case DownloadItem::COMPLETE:
       if (download_->auto_opened()) {
         parent_->RemoveDownloadView(this);  // This will delete us!
         return;
       }
       StopDownloadProgress();
       complete_animation_.reset(new SlideAnimation(this));
       complete_animation_->SetSlideDuration(kCompleteAnimationDurationMs);
-      complete_animation_->SetTweenType(SlideAnimation::NONE);
+      complete_animation_->SetTweenType(Tween::LINEAR);
       complete_animation_->Show();
       if (status_text.empty())
         show_status_text_ = false;
       SchedulePaint();
       LoadIcon();
       break;
     case DownloadItem::CANCELLED:
       StopDownloadProgress();
       LoadIcon();
       break;
@@ skipping 275 matching lines @@
   // triggered only when we think the status might change.
   if (icon) {
     if (!IsDangerousMode()) {
       if (download_->state() == DownloadItem::IN_PROGRESS) {
         download_util::PaintDownloadProgress(canvas, this, 0, 0,
                                              progress_angle_,
                                              download_->PercentComplete(),
                                              download_util::SMALL);
       } else if (download_->state() == DownloadItem::COMPLETE &&
                  complete_animation_.get() &&
-                 complete_animation_->IsAnimating()) {
+                 complete_animation_->is_animating()) {
         download_util::PaintDownloadComplete(canvas, this, 0, 0,
             complete_animation_->GetCurrentValue(),
             download_util::SMALL);
       }
     }
 
     // Draw the icon image.
     int mirrored_x = MirroredXWithWidthInsideView(
         download_util::kSmallProgressIconOffset, icon->width());
     if (IsEnabled()) {
@@ skipping 107 matching lines @@
   drop_hover_animation_->Hide();
 }
 
 // Display the context menu for this item.
 bool DownloadItemView::OnMousePressed(const views::MouseEvent& event) {
   // Mouse should not activate us in dangerous mode.
   if (IsDangerousMode())
     return true;
 
   // Stop any completion animation.
-  if (complete_animation_.get() && complete_animation_->IsAnimating())
+  if (complete_animation_.get() && complete_animation_->is_animating())
     complete_animation_->End();
 
   if (event.IsOnlyLeftMouseButton()) {
     gfx::Point point(event.location());
     if (!InDropDownButtonXCoordinateRange(event.x())) {
       SetState(PUSHED, NORMAL);
       return true;
     }
 
     drop_down_pressed_ = true;
@@ skipping 210 matching lines @@
 void DownloadItemView::Reenable() {
   disabled_while_opening_ = false;
   SetEnabled(true);  // Triggers a repaint.
 }
 
 bool DownloadItemView::InDropDownButtonXCoordinateRange(int x) {
   if (x > drop_down_x_left_ && x < drop_down_x_right_)
     return true;
   return false;
 }