chrome/browser/views/frame/browser_view.cc - Issue 1961001: Refactors animation to allow for cleaner subclassing. I'm doing this

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/frame/browser_view.cc

Issue 1961001: Refactors animation to allow for cleaner subclassing. I'm doing this (Closed)

Patch Set: Incorporated review feedback Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/views/frame/browser_view.cc

diff --git a/chrome/browser/views/frame/browser_view.cc b/chrome/browser/views/frame/browser_view.cc

index 203b921df5fb8b18fe929ad25a47dd149eae62b7..ade9dc06adea44ee29c5db10b30fc0976fdffabe 100644

--- a/chrome/browser/views/frame/browser_view.cc

+++ b/chrome/browser/views/frame/browser_view.cc

@@ -890,10 +890,7 @@ bool BrowserView::IsBookmarkBarVisible() const {

}

bool BrowserView::IsBookmarkBarAnimating() const {

- if (bookmark_bar_view_.get() &&

- bookmark_bar_view_->IsAnimating())

- return true;

- return false;

+ return bookmark_bar_view_.get() && bookmark_bar_view_->is_animating();

}

bool BrowserView::IsToolbarVisible() const {