chrome/browser/views/bookmark_bar_view.cc - Issue 1961001: Refactors animation to allow for cleaner subclassing. I'm doing this

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/bookmark_bar_view.cc

Issue 1961001: Refactors animation to allow for cleaner subclassing. I'm doing this (Closed)

Patch Set: Incorporated review feedback Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/views/bookmark_bar_view.cc

diff --git a/chrome/browser/views/bookmark_bar_view.cc b/chrome/browser/views/bookmark_bar_view.cc

index 0cf4a71ea17d7c9a994ee008a291574fa8299193..0d76874bfa77aba2f9c53d178a66c510d9ad8f99 100644

--- a/chrome/browser/views/bookmark_bar_view.cc

+++ b/chrome/browser/views/bookmark_bar_view.cc

@@ -1105,7 +1105,7 @@ void BookmarkBarView::WriteDragData(View* sender,

}

int BookmarkBarView::GetDragOperations(View* sender, const gfx::Point& p) {

- if (size_animation_->IsAnimating() ||

+ if (size_animation_->is_animating() ||

(size_animation_->GetCurrentValue() == 0 && !OnNewTabPage())) {

// Don't let the user drag while animating open or we're closed (and not on

// the new tab page, on the new tab page size_animation_ is always 0). This