chrome/browser/gtk/tabs/tab_strip_gtk.cc - Issue 1961001: Refactors animation to allow for cleaner subclassing. I'm doing this

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/tabs/tab_strip_gtk.cc

Issue 1961001: Refactors animation to allow for cleaner subclassing. I'm doing this (Closed)

Patch Set: Incorporated review feedback Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/gtk/tabs/tab_strip_gtk.cc

diff --git a/chrome/browser/gtk/tabs/tab_strip_gtk.cc b/chrome/browser/gtk/tabs/tab_strip_gtk.cc

index 8d1d1c854792e9dae86404c2905014bd0fc986ea..7b3bf734a23a31aa4eff8cb1c9949e1ee5ebdc80 100644

--- a/chrome/browser/gtk/tabs/tab_strip_gtk.cc

+++ b/chrome/browser/gtk/tabs/tab_strip_gtk.cc

@@ -130,7 +130,7 @@ class TabStripGtk::TabAnimation : public AnimationDelegate {

void Start() {

animation_.SetSlideDuration(GetDuration());

- animation_.SetTweenType(SlideAnimation::EASE_OUT);

+ animation_.SetTweenType(Tween::EASE_OUT);

if (!animation_.IsShowing()) {

animation_.Reset();

animation_.Show();