chrome/browser/views/tabs/tab_strip.cc - Issue 1961001: Refactors animation to allow for cleaner subclassing. I'm doing this

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/tabs/tab_strip.cc

Issue 1961001: Refactors animation to allow for cleaner subclassing. I'm doing this (Closed)

Patch Set: Incorporated review feedback Created 10 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/views/tabs/tab_strip.cc

diff --git a/chrome/browser/views/tabs/tab_strip.cc b/chrome/browser/views/tabs/tab_strip.cc

index a6e11d32d24ff360f5a71224391031ca63dfb0d5..ced65ab4c27ec8a5c2e9f83256904177305b3f32 100644

--- a/chrome/browser/views/tabs/tab_strip.cc

+++ b/chrome/browser/views/tabs/tab_strip.cc

@@ -1529,7 +1529,7 @@ void TabStrip::NewTabAnimation2Done() {

SlideAnimation* animation = new SlideAnimation(NULL);

animation->SetSlideDuration(kNewTab3DurationMs);

- animation->SetTweenType(SlideAnimation::EASE_IN_OUT);

+ animation->SetTweenType(Tween::EASE_IN_OUT);

// BoundsAnimator takes ownership of animation.

bounds_animator_.SetAnimationForView(tab_data_.back().tab, animation);

« no previous file with comments | « chrome/browser/views/tabs/tab_renderer.cc ('k') | views/animation/bounds_animator.cc » ('j') | no next file with comments »