Pepper SRPC proxy style and type nits

Pepper SRPC proxy style and type nits
 - use NACL_PRId32 for PP_Instance, PP_Resource, and PP_Module instead of NACL_PRIu32 in DebugPrintf
 - use PP_ToBool or PP_FromBool to cast between PP_Bool and bool

BUG=none
TEST=ui_test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118253

[Takashi Toyoshima, 2012-01-18 10:22:57]

Hi,

It's trivial but huge CL...I'm sorry.
I casually start this nits bashing, but it's tough than expected.

[dmichael (off chromium), 2012-01-18 18:47:55]

I'm not super excited about implicitly converting bool to int32_t:
int32_t success = PP_ToBool(some_pp_bool);
...but I think it's well-defined, so it's fine.

But it might be worth changing %d to %NACL_PRId32 in places where you
DebugPrintf "success". int (%d) is 32-bits on all our platforms, so it's
probably fine, but if the compiler was evaluating, it would warn you for the
"untrusted" parts of the code since int32_t is actually typedefed to long in the
NaCl newlib toolchain.

Rubber-stamp lgtm

http://codereview.chromium.org/9253011/diff/2001/ppapi/native_client/src/shar...
File
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_audio_config_rpc_server.cc
(right):

http://codereview.chromium.org/9253011/diff/2001/ppapi/native_client/src/shar...
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_audio_config_rpc_server.cc:80:
DebugPrintf("PPB_AudioConfig::IsAudioConfig: success=%d\n", *success);
should be NACL_PRId32 (here and for other int32_t variables; it looks like all
the "success" follow this pattern and use %d currently)

[dmichael (off chromium), 2012-01-18 18:48:16]

lgtm

PS: Thanks a bunch for doing this!

[Takashi Toyoshima, 2012-01-19 02:58:24]

http://codereview.chromium.org/9253011/diff/2001/ppapi/native_client/src/shar...
File
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_audio_config_rpc_server.cc
(right):

http://codereview.chromium.org/9253011/diff/2001/ppapi/native_client/src/shar...
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_audio_config_rpc_server.cc:80:
DebugPrintf("PPB_AudioConfig::IsAudioConfig: success=%d\n", *success);
On 2012/01/18 18:47:56, dmichael wrote:
> should be NACL_PRId32 (here and for other int32_t variables; it looks like all
> the "success" follow this pattern and use %d currently)

Done.

[commit-bot: I haz the power, 2012-01-19 03:05:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/9253011/9001

[commit-bot: I haz the power, 2012-01-19 03:06:12]

Presubmit check for 9253011-9001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2012 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
 
ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_response_info_rpc_server.cc
\
  ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_audio_config.cc \
  ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_buffer.cc \
  ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_core.cc \
  ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_image_data.cc

Presubmit checks took 5.6s to calculate.

[commit-bot: I haz the power, 2012-01-19 03:16:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/9253011/11001

[commit-bot: I haz the power, 2012-01-19 06:18:19]

Change committed as 118253