ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc - Issue 9253011: Pepper SRPC proxy style and type nits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_find.cc ('k') | ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc

diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc

index 9f2d717b7579013c0102f6da47e2f53f3d0b2f09..0217db0472383c9cbe8f7a5df9b99b6797f9db88 100644

--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc

+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp_input_event.cc

@@ -20,8 +20,8 @@ namespace ppapi_proxy {

namespace {

PP_Bool HandleInputEvent(PP_Instance instance, PP_Resource input_event) {

- DebugPrintf("PPP_InputEvent::HandleInputEvent: instance=%"NACL_PRIu32", "

- "input_event = %"NACL_PRIu32"\n",

+ DebugPrintf("PPP_InputEvent::HandleInputEvent: instance=%"NACL_PRId32", "

+ "input_event = %"NACL_PRId32"\n",

instance, input_event);

PP_Var character_text = PP_MakeUndefined();

@@ -109,7 +109,7 @@ PP_Bool HandleInputEvent(PP_Instance instance, PP_Resource input_event) {

// or PP_TRUE. Otherwise, there's an error in the proxy.

DCHECK((handled == static_cast<int32_t>(PP_FALSE) ||

(handled == static_cast<int32_t>(PP_TRUE))));

- PP_Bool handled_bool = static_cast<PP_Bool>(handled);

+ PP_Bool handled_bool = PP_FromBool(handled);

return handled_bool;

}