Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_socket_private_rpc_server.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_socket_private_rpc_server.cc
diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_socket_private_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_socket_private_rpc_server.cc
index 1780da599e4d75d9b7beb6423aa324d8fec69942..01c68973b23b299971ed7e8ab3de01d131f961a5 100644
--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_socket_private_rpc_server.cc
+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_socket_private_rpc_server.cc
@@ -33,7 +33,7 @@ void PpbTCPSocketPrivateRpcServer::PPB_TCPSocket_Private_Create(
*resource = PPBTCPSocketPrivateInterface()->Create(instance);
- DebugPrintf("PPB_TCPSocket_Private::Create: resource=%"NACL_PRIu32"\n",
+ DebugPrintf("PPB_TCPSocket_Private::Create: resource=%"NACL_PRId32"\n",
*resource);
}
@@ -49,11 +49,9 @@ void PpbTCPSocketPrivateRpcServer::PPB_TCPSocket_Private_IsTCPSocket(
PP_Bool pp_success =
PPBTCPSocketPrivateInterface()->IsTCPSocket(resource);
-
- DebugPrintf("PPB_TCPSocket_Private::IsTCPSocket: pp_success=%d\n",
- pp_success);
-
- *is_tcp_socket = (pp_success == PP_TRUE);
+ *is_tcp_socket = PP_ToBool(pp_success);
+ DebugPrintf("PPB_TCPSocket_Private::IsTCPSocket: is_tcp_socket=%d\n",
+ *is_tcp_socket);
}
void PpbTCPSocketPrivateRpcServer::PPB_TCPSocket_Private_Connect(
@@ -138,11 +136,9 @@ void PpbTCPSocketPrivateRpcServer::PPB_TCPSocket_Private_GetLocalAddress(
PP_Bool pp_success = PPBTCPSocketPrivateInterface()->GetLocalAddress(
tcp_socket, reinterpret_cast<struct PP_NetAddress_Private*>(local_addr));
-
- DebugPrintf("PPB_TCPSocket_Private::GetLocalAddress: pp_success=%d\n",
- pp_success);
-
- *success = (pp_success == PP_TRUE);
+ *success = PP_ToBool(pp_success);
+ DebugPrintf("PPB_TCPSocket_Private::GetLocalAddress: success=%d\n",
+ *success);
rpc->result = NACL_SRPC_RESULT_OK;
}
@@ -165,11 +161,9 @@ void PpbTCPSocketPrivateRpcServer::PPB_TCPSocket_Private_GetRemoteAddress(
PPBTCPSocketPrivateInterface()->GetRemoteAddress(
tcp_socket,
reinterpret_cast<struct PP_NetAddress_Private*>(remote_addr));
-
- DebugPrintf("PPB_TCPSocket_Private::GetRemoteAddress: pp_success=%d\n",
- pp_success);
-
- *success = (pp_success == PP_TRUE);
+ *success = PP_ToBool(pp_success);
+ DebugPrintf("PPB_TCPSocket_Private::GetRemoteAddress: success=%d\n",
+ *success);
rpc->result = NACL_SRPC_RESULT_OK;
}
@@ -303,7 +297,7 @@ void PpbTCPSocketPrivateRpcServer::PPB_TCPSocket_Private_Disconnect(
NaClSrpcClosureRunner runner(done);
rpc->result = NACL_SRPC_RESULT_OK;
- DebugPrintf("PPB_TCPSocket_Private::Disconnect: tcp_socket=%"NACL_PRIu32"\n",
+ DebugPrintf("PPB_TCPSocket_Private::Disconnect: tcp_socket=%"NACL_PRId32"\n",
tcp_socket);
PPBTCPSocketPrivateInterface()->Disconnect(tcp_socket);

Powered by Google App Engine
This is Rietveld 408576698