Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_fullscreen.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "native_client/src/shared/ppapi_proxy/plugin_instance_data.h" 5 #include "native_client/src/shared/ppapi_proxy/plugin_instance_data.h"
6 #include "native_client/src/shared/ppapi_proxy/plugin_ppb_fullscreen.h" 6 #include "native_client/src/shared/ppapi_proxy/plugin_ppb_fullscreen.h"
7 #include "native_client/src/shared/ppapi_proxy/plugin_globals.h" 7 #include "native_client/src/shared/ppapi_proxy/plugin_globals.h"
8 #include "native_client/src/shared/ppapi_proxy/utility.h" 8 #include "native_client/src/shared/ppapi_proxy/utility.h"
9 #include "ppapi/c/pp_size.h" 9 #include "ppapi/c/pp_size.h"
10 #include "ppapi/c/ppb_fullscreen.h" 10 #include "ppapi/c/ppb_fullscreen.h"
11 #include "srpcgen/ppb_rpc.h" 11 #include "srpcgen/ppb_rpc.h"
12 12
13 namespace ppapi_proxy { 13 namespace ppapi_proxy {
14 14
15 namespace { 15 namespace {
16 16
17 PP_Bool IsFullscreen(PP_Instance instance) { 17 PP_Bool IsFullscreen(PP_Instance instance) {
18 DebugPrintf("PPB_Fullscreen::IsFullscreen: instance=%"NACL_PRIu32"\n", 18 DebugPrintf("PPB_Fullscreen::IsFullscreen: instance=%"NACL_PRId32"\n",
19 instance); 19 instance);
20 return PluginInstanceData::IsFullscreen(instance) ? PP_TRUE : PP_FALSE; 20 return PP_FromBool(PluginInstanceData::IsFullscreen(instance));
21 } 21 }
22 22
23 23
24 PP_Bool SetFullscreen(PP_Instance instance, PP_Bool fullscreen) { 24 PP_Bool SetFullscreen(PP_Instance instance, PP_Bool fullscreen) {
25 DebugPrintf("PPB_Fullscreen::SetFullscreen: " 25 DebugPrintf("PPB_Fullscreen::SetFullscreen: "
26 "instance=%"NACL_PRIu32" fullscreen=%d\n", instance, fullscreen); 26 "instance=%"NACL_PRId32" fullscreen=%d\n", instance, fullscreen);
27 27
28 int32_t success; 28 int32_t success;
29 NaClSrpcError srpc_result = 29 NaClSrpcError srpc_result =
30 PpbFullscreenRpcClient::PPB_Fullscreen_SetFullscreen( 30 PpbFullscreenRpcClient::PPB_Fullscreen_SetFullscreen(
31 GetMainSrpcChannel(), 31 GetMainSrpcChannel(),
32 instance, 32 instance,
33 static_cast<int32_t>(fullscreen), 33 static_cast<int32_t>(fullscreen),
34 &success); 34 &success);
35 DebugPrintf("PPB_Fullscreen::SetFullscreen: %s\n", 35 DebugPrintf("PPB_Fullscreen::SetFullscreen: %s\n",
36 NaClSrpcErrorString(srpc_result)); 36 NaClSrpcErrorString(srpc_result));
37 37
38 if (srpc_result == NACL_SRPC_RESULT_OK && success) 38 if (srpc_result == NACL_SRPC_RESULT_OK && success)
39 return PP_TRUE; 39 return PP_TRUE;
40 return PP_FALSE; 40 return PP_FALSE;
41 } 41 }
42 42
43 43
44 PP_Bool GetScreenSize(PP_Instance instance, struct PP_Size* size) { 44 PP_Bool GetScreenSize(PP_Instance instance, struct PP_Size* size) {
45 DebugPrintf("PPB_Fullscreen::GetScreenSize: instance=%"NACL_PRIu32"\n", 45 DebugPrintf("PPB_Fullscreen::GetScreenSize: instance=%"NACL_PRId32"\n",
46 instance); 46 instance);
47 if (size == NULL) 47 if (size == NULL)
48 return PP_FALSE; 48 return PP_FALSE;
49 49
50 int32_t success; 50 int32_t success;
51 nacl_abi_size_t size_bytes = 51 nacl_abi_size_t size_bytes =
52 static_cast<nacl_abi_size_t>(sizeof(struct PP_Size)); 52 static_cast<nacl_abi_size_t>(sizeof(struct PP_Size));
53 NaClSrpcError srpc_result = 53 NaClSrpcError srpc_result =
54 PpbFullscreenRpcClient::PPB_Fullscreen_GetScreenSize( 54 PpbFullscreenRpcClient::PPB_Fullscreen_GetScreenSize(
55 GetMainSrpcChannel(), 55 GetMainSrpcChannel(),
(...skipping 14 matching lines...) Expand all
70 const PPB_Fullscreen* PluginFullscreen::GetInterface() { 70 const PPB_Fullscreen* PluginFullscreen::GetInterface() {
71 static const PPB_Fullscreen fullscreen_interface = { 71 static const PPB_Fullscreen fullscreen_interface = {
72 IsFullscreen, 72 IsFullscreen,
73 SetFullscreen, 73 SetFullscreen,
74 GetScreenSize 74 GetScreenSize
75 }; 75 };
76 return &fullscreen_interface; 76 return &fullscreen_interface;
77 } 77 }
78 78
79 } // namespace ppapi_proxy 79 } // namespace ppapi_proxy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698