ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_selection_rpc_server.cc - Issue 9253011: Pepper SRPC proxy style and type nits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_selection_rpc_server.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_scrollbar_rpc_server.cc ('k') | ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_zoom_rpc_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_selection_rpc_server.cc

diff --git a/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_selection_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_selection_rpc_server.cc

index 37f4c2586bb46132f9eb677d5fefde8b2552d0a9..618bdc09d970a90dc8b660ce322773819856ab86 100644

--- a/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_selection_rpc_server.cc

+++ b/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_selection_rpc_server.cc

@@ -1,4 +1,4 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

@@ -31,7 +31,7 @@ void PppSelectionRpcServer::PPP_Selection_GetSelectedText(

rpc->result = NACL_SRPC_RESULT_APP_ERROR;

NaClSrpcClosureRunner runner(done);

- PP_Bool pp_html = html ? PP_TRUE : PP_FALSE;

+ PP_Bool pp_html = PP_FromBool(html);

PP_Var pp_selected_text =

PPPSelectionInterface()->GetSelectedText(instance, pp_html);

if (!SerializeTo(&pp_selected_text, selected_text, selected_text_bytes))