Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_scrollbar.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "native_client/src/shared/ppapi_proxy/plugin_ppb_scrollbar.h" 5 #include "native_client/src/shared/ppapi_proxy/plugin_ppb_scrollbar.h"
6 6
7 #include "native_client/src/include/portability.h" 7 #include "native_client/src/include/portability.h"
8 #include "native_client/src/shared/ppapi_proxy/plugin_callback.h" 8 #include "native_client/src/shared/ppapi_proxy/plugin_callback.h"
9 #include "native_client/src/shared/ppapi_proxy/plugin_globals.h" 9 #include "native_client/src/shared/ppapi_proxy/plugin_globals.h"
10 #include "native_client/src/shared/ppapi_proxy/utility.h" 10 #include "native_client/src/shared/ppapi_proxy/utility.h"
11 #include "ppapi/c/dev/ppb_scrollbar_dev.h" 11 #include "ppapi/c/dev/ppb_scrollbar_dev.h"
12 #include "ppapi/c/pp_completion_callback.h" 12 #include "ppapi/c/pp_completion_callback.h"
13 #include "ppapi/c/pp_errors.h" 13 #include "ppapi/c/pp_errors.h"
14 #include "ppapi/c/pp_rect.h" 14 #include "ppapi/c/pp_rect.h"
15 #include "srpcgen/ppb_rpc.h" 15 #include "srpcgen/ppb_rpc.h"
16 16
17 namespace ppapi_proxy { 17 namespace ppapi_proxy {
18 18
19 namespace { 19 namespace {
20 20
21 const nacl_abi_size_t kPPRectBytes = 21 const nacl_abi_size_t kPPRectBytes =
22 static_cast<nacl_abi_size_t>(sizeof(struct PP_Rect)); 22 static_cast<nacl_abi_size_t>(sizeof(struct PP_Rect));
23 23
24 PP_Resource Create(PP_Instance instance, PP_Bool vertical) { 24 PP_Resource Create(PP_Instance instance, PP_Bool vertical) {
25 DebugPrintf("PPB_Scrollbar::Create: " 25 DebugPrintf("PPB_Scrollbar::Create: "
26 "instance=%"NACL_PRIu32"\n", 26 "instance=%"NACL_PRId32"\n",
27 instance); 27 instance);
28 28
29 PP_Resource scrollbar = kInvalidResourceId; 29 PP_Resource scrollbar = kInvalidResourceId;
30 NaClSrpcError srpc_result = 30 NaClSrpcError srpc_result =
31 PpbScrollbarRpcClient::PPB_Scrollbar_Create( 31 PpbScrollbarRpcClient::PPB_Scrollbar_Create(
32 GetMainSrpcChannel(), 32 GetMainSrpcChannel(),
33 instance, 33 instance,
34 vertical, 34 vertical,
35 &scrollbar); 35 &scrollbar);
36 36
37 DebugPrintf("PPB_Scrollbar::Create: %s\n", 37 DebugPrintf("PPB_Scrollbar::Create: %s\n",
38 NaClSrpcErrorString(srpc_result)); 38 NaClSrpcErrorString(srpc_result));
39 return scrollbar; 39 return scrollbar;
40 } 40 }
41 41
42 PP_Bool IsScrollbar(PP_Resource resource) { 42 PP_Bool IsScrollbar(PP_Resource resource) {
43 DebugPrintf("PPB_Scrollbar::IsScrollbar: " 43 DebugPrintf("PPB_Scrollbar::IsScrollbar: "
44 "resource=%"NACL_PRIu32"\n", 44 "resource=%"NACL_PRId32"\n",
45 resource); 45 resource);
46 46
47 int32_t is_scrollbar = 0; 47 int32_t is_scrollbar = 0;
48 NaClSrpcError srpc_result = 48 NaClSrpcError srpc_result =
49 PpbScrollbarRpcClient::PPB_Scrollbar_IsScrollbar( 49 PpbScrollbarRpcClient::PPB_Scrollbar_IsScrollbar(
50 GetMainSrpcChannel(), 50 GetMainSrpcChannel(),
51 resource, 51 resource,
52 &is_scrollbar); 52 &is_scrollbar);
53 53
54 DebugPrintf("PPB_Scrollbar::IsScrollbar: %s\n", 54 DebugPrintf("PPB_Scrollbar::IsScrollbar: %s\n",
(...skipping 15 matching lines...) Expand all
70 &thickness); 70 &thickness);
71 71
72 DebugPrintf("PPB_Scrollbar::GetThickness: %s\n", 72 DebugPrintf("PPB_Scrollbar::GetThickness: %s\n",
73 NaClSrpcErrorString(srpc_result)); 73 NaClSrpcErrorString(srpc_result));
74 74
75 return thickness; 75 return thickness;
76 } 76 }
77 77
78 PP_Bool IsOverlay(PP_Resource resource) { 78 PP_Bool IsOverlay(PP_Resource resource) {
79 DebugPrintf("PPB_Scrollbar::IsOverlay: " 79 DebugPrintf("PPB_Scrollbar::IsOverlay: "
80 "resource=%"NACL_PRIu32"\n", 80 "resource=%"NACL_PRId32"\n",
81 resource); 81 resource);
82 82
83 int32_t is_overlay = 0; 83 int32_t is_overlay = 0;
84 NaClSrpcError srpc_result = 84 NaClSrpcError srpc_result =
85 PpbScrollbarRpcClient::PPB_Scrollbar_IsOverlay( 85 PpbScrollbarRpcClient::PPB_Scrollbar_IsOverlay(
86 GetMainSrpcChannel(), 86 GetMainSrpcChannel(),
87 resource, 87 resource,
88 &is_overlay); 88 &is_overlay);
89 89
90 DebugPrintf("PPB_Scrollbar::IsOverlay: %s\n", 90 DebugPrintf("PPB_Scrollbar::IsOverlay: %s\n",
91 NaClSrpcErrorString(srpc_result)); 91 NaClSrpcErrorString(srpc_result));
92 92
93 if (srpc_result == NACL_SRPC_RESULT_OK && is_overlay) 93 if (srpc_result == NACL_SRPC_RESULT_OK && is_overlay)
94 return PP_TRUE; 94 return PP_TRUE;
95 return PP_FALSE; 95 return PP_FALSE;
96 } 96 }
97 97
98 uint32_t GetValue(PP_Resource scrollbar) { 98 uint32_t GetValue(PP_Resource scrollbar) {
99 DebugPrintf("PPB_Scrollbar::GetValue: " 99 DebugPrintf("PPB_Scrollbar::GetValue: "
100 "scrollbar=%"NACL_PRIu32"\n", 100 "scrollbar=%"NACL_PRId32"\n",
101 scrollbar); 101 scrollbar);
102 102
103 int32_t value = 0; 103 int32_t value = 0;
104 NaClSrpcError srpc_result = 104 NaClSrpcError srpc_result =
105 PpbScrollbarRpcClient::PPB_Scrollbar_GetValue( 105 PpbScrollbarRpcClient::PPB_Scrollbar_GetValue(
106 GetMainSrpcChannel(), 106 GetMainSrpcChannel(),
107 scrollbar, 107 scrollbar,
108 &value); 108 &value);
109 109
110 DebugPrintf("PPB_Scrollbar::GetValue: %s\n", 110 DebugPrintf("PPB_Scrollbar::GetValue: %s\n",
111 NaClSrpcErrorString(srpc_result)); 111 NaClSrpcErrorString(srpc_result));
112 112
113 return value; 113 return value;
114 } 114 }
115 115
116 void SetValue(PP_Resource scrollbar, uint32_t value) { 116 void SetValue(PP_Resource scrollbar, uint32_t value) {
117 DebugPrintf("PPB_Scrollbar::SetValue: " 117 DebugPrintf("PPB_Scrollbar::SetValue: "
118 "scrollbar=%"NACL_PRIu32"\n", 118 "scrollbar=%"NACL_PRId32"\n",
119 scrollbar); 119 scrollbar);
120 120
121 NaClSrpcError srpc_result = 121 NaClSrpcError srpc_result =
122 PpbScrollbarRpcClient::PPB_Scrollbar_SetValue( 122 PpbScrollbarRpcClient::PPB_Scrollbar_SetValue(
123 GetMainSrpcChannel(), 123 GetMainSrpcChannel(),
124 scrollbar, 124 scrollbar,
125 value); 125 value);
126 126
127 DebugPrintf("PPB_Scrollbar::SetValue: %s\n", 127 DebugPrintf("PPB_Scrollbar::SetValue: %s\n",
128 NaClSrpcErrorString(srpc_result)); 128 NaClSrpcErrorString(srpc_result));
129 } 129 }
130 130
131 void SetDocumentSize(PP_Resource scrollbar, uint32_t size) { 131 void SetDocumentSize(PP_Resource scrollbar, uint32_t size) {
132 DebugPrintf("PPB_Scrollbar::SetDocumentSize: " 132 DebugPrintf("PPB_Scrollbar::SetDocumentSize: "
133 "scrollbar=%"NACL_PRIu32"\n", scrollbar); 133 "scrollbar=%"NACL_PRId32"\n", scrollbar);
134 134
135 NaClSrpcError srpc_result = 135 NaClSrpcError srpc_result =
136 PpbScrollbarRpcClient::PPB_Scrollbar_SetDocumentSize( 136 PpbScrollbarRpcClient::PPB_Scrollbar_SetDocumentSize(
137 GetMainSrpcChannel(), 137 GetMainSrpcChannel(),
138 scrollbar, 138 scrollbar,
139 size); 139 size);
140 140
141 DebugPrintf("PPB_Scrollbar::SetDocumentSize: %s\n", 141 DebugPrintf("PPB_Scrollbar::SetDocumentSize: %s\n",
142 NaClSrpcErrorString(srpc_result)); 142 NaClSrpcErrorString(srpc_result));
143 } 143 }
144 144
145 void SetTickMarks(PP_Resource scrollbar, 145 void SetTickMarks(PP_Resource scrollbar,
146 const struct PP_Rect* tick_marks, 146 const struct PP_Rect* tick_marks,
147 uint32_t count) { 147 uint32_t count) {
148 DebugPrintf("PPB_Scrollbar::SetTickMarks: " 148 DebugPrintf("PPB_Scrollbar::SetTickMarks: "
149 "scrollbar=%"NACL_PRIu32"\n", 149 "scrollbar=%"NACL_PRId32"\n",
150 scrollbar); 150 scrollbar);
151 151
152 nacl_abi_size_t tick_marks_bytes = kPPRectBytes * count; 152 nacl_abi_size_t tick_marks_bytes = kPPRectBytes * count;
153 NaClSrpcError srpc_result = 153 NaClSrpcError srpc_result =
154 PpbScrollbarRpcClient::PPB_Scrollbar_SetTickMarks( 154 PpbScrollbarRpcClient::PPB_Scrollbar_SetTickMarks(
155 GetMainSrpcChannel(), 155 GetMainSrpcChannel(),
156 scrollbar, 156 scrollbar,
157 tick_marks_bytes, 157 tick_marks_bytes,
158 reinterpret_cast<char*>(const_cast<struct PP_Rect*>(tick_marks)), 158 reinterpret_cast<char*>(const_cast<struct PP_Rect*>(tick_marks)),
159 count); 159 count);
160 160
161 DebugPrintf("PPB_Scrollbar::SetTickMarks: %s\n", 161 DebugPrintf("PPB_Scrollbar::SetTickMarks: %s\n",
162 NaClSrpcErrorString(srpc_result)); 162 NaClSrpcErrorString(srpc_result));
163 } 163 }
164 164
165 void ScrollBy(PP_Resource scrollbar, 165 void ScrollBy(PP_Resource scrollbar,
166 PP_ScrollBy_Dev unit, 166 PP_ScrollBy_Dev unit,
167 int32_t multiplier) { 167 int32_t multiplier) {
168 DebugPrintf("PPB_Scrollbar::ScrollBy: " 168 DebugPrintf("PPB_Scrollbar::ScrollBy: "
169 "scrollbar=%"NACL_PRIu32"\n", 169 "scrollbar=%"NACL_PRId32"\n",
170 scrollbar); 170 scrollbar);
171 171
172 NaClSrpcError srpc_result = 172 NaClSrpcError srpc_result =
173 PpbScrollbarRpcClient::PPB_Scrollbar_ScrollBy( 173 PpbScrollbarRpcClient::PPB_Scrollbar_ScrollBy(
174 GetMainSrpcChannel(), 174 GetMainSrpcChannel(),
175 scrollbar, 175 scrollbar,
176 unit, 176 unit,
177 multiplier); 177 multiplier);
178 178
179 DebugPrintf("PPB_Scrollbar::ScrollBy: %s\n", 179 DebugPrintf("PPB_Scrollbar::ScrollBy: %s\n",
(...skipping 11 matching lines...) Expand all
191 GetValue, 191 GetValue,
192 SetValue, 192 SetValue,
193 SetDocumentSize, 193 SetDocumentSize,
194 SetTickMarks, 194 SetTickMarks,
195 ScrollBy 195 ScrollBy
196 }; 196 };
197 return &scrollbar_interface; 197 return &scrollbar_interface;
198 } 198 }
199 199
200 } // namespace ppapi_proxy 200 } // namespace ppapi_proxy
201
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698