Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_find_rpc_server.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_find_rpc_server.cc
diff --git a/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_find_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_find_rpc_server.cc
index d7413f82c375e290737cdc41fa397fe494b11cd0..a5d596ebbefb2042ca735b62cf582d7707fa3301 100644
--- a/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_find_rpc_server.cc
+++ b/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppp_find_rpc_server.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
@@ -32,10 +32,10 @@ void PppFindRpcServer::PPP_Find_StartFind(
PP_Bool pp_supports_find = PPPFindInterface()->StartFind(
instance,
text,
- case_sensitive ? PP_TRUE : PP_FALSE);
- *supports_find = pp_supports_find == PP_TRUE;
+ PP_FromBool(case_sensitive));
+ *supports_find = PP_ToBool(pp_supports_find);
- DebugPrintf("PPP_Find::StartFind: pp_supports_find=%d\n", pp_supports_find);
+ DebugPrintf("PPP_Find::StartFind: supports_find=%d\n", *supports_find);
rpc->result = NACL_SRPC_RESULT_OK;
}
@@ -48,7 +48,7 @@ void PppFindRpcServer::PPP_Find_SelectFindResult(
rpc->result = NACL_SRPC_RESULT_APP_ERROR;
NaClSrpcClosureRunner runner(done);
- PPPFindInterface()->SelectFindResult(instance, forward ? PP_TRUE : PP_FALSE);
+ PPPFindInterface()->SelectFindResult(instance, PP_FromBool(forward));
DebugPrintf("PPP_Find::SelectFindResult\n");
rpc->result = NACL_SRPC_RESULT_OK;
}

Powered by Google App Engine
This is Rietveld 408576698