ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_testing_rpc_server.cc - Issue 9253011: Pepper SRPC proxy style and type nits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_testing_rpc_server.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_tcp_socket_private_rpc_server.cc ('k') | ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_udp_socket_private_rpc_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_testing_rpc_server.cc

diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_testing_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_testing_rpc_server.cc

index 8e9838401058f539120f78a6fee2bf1bbfa7d77e..8fb9d6f5335066b28d58c71f13c3cde800e1db0a 100644

--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_testing_rpc_server.cc

+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_testing_rpc_server.cc

@@ -39,7 +39,7 @@ void PpbTestingRpcServer::PPB_Testing_ReadImageData(

PPBTestingInterface()->ReadImageData(device_context_2d,

image,

pp_top_left);

- *success = (pp_success == PP_TRUE);

+ *success = PP_ToBool(pp_success);

DebugPrintf("PPB_Testing_Dev::ReadImageData: "

"success=%"NACL_PRId32"\n", *success);

@@ -55,7 +55,7 @@ void PpbTestingRpcServer::PPB_Testing_RunMessageLoop(

PPBTestingInterface()->RunMessageLoop(instance);

- DebugPrintf("PPB_Testing_Dev::RunMessageLoop: instance=%"NACL_PRIu32"\n",

+ DebugPrintf("PPB_Testing_Dev::RunMessageLoop: instance=%"NACL_PRId32"\n",

instance);

rpc->result = NACL_SRPC_RESULT_OK;

}

@@ -69,7 +69,7 @@ void PpbTestingRpcServer::PPB_Testing_QuitMessageLoop(

PPBTestingInterface()->QuitMessageLoop(instance);

- DebugPrintf("PPB_Testing_Dev::QuitMessageLoop: instance=%"NACL_PRIu32"\n",

+ DebugPrintf("PPB_Testing_Dev::QuitMessageLoop: instance=%"NACL_PRId32"\n",

instance);

rpc->result = NACL_SRPC_RESULT_OK;

}

@@ -87,7 +87,7 @@ void PpbTestingRpcServer::PPB_Testing_GetLiveObjectsForInstance(

*live_objects = pp_live_objects;

DebugPrintf("PPB_Testing_Dev::GetLiveObjectsForInstance: "

- "live_objects=%"NACL_PRIu32"\n", *live_objects);

+ "live_objects=%"NACL_PRId32"\n", *live_objects);

rpc->result = NACL_SRPC_RESULT_OK;

}

@@ -101,7 +101,7 @@ void PpbTestingRpcServer::PPB_Testing_SimulateInputEvent(

PPBTestingInterface()->SimulateInputEvent(instance, input_event);

- DebugPrintf("PPB_Testing::SimulateInputEvent: instance=%"NACL_PRIu32"\n",

+ DebugPrintf("PPB_Testing::SimulateInputEvent: instance=%"NACL_PRId32"\n",

instance);

rpc->result = NACL_SRPC_RESULT_OK;

}