ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_response_info_rpc_server.cc - Issue 9253011: Pepper SRPC proxy style and type nits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_response_info_rpc_server.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc ('k') | ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_widget_rpc_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_response_info_rpc_server.cc

diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_response_info_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_response_info_rpc_server.cc

index d2f5adb50576b324cbfc04a6707055f1da39f808..4bb787fd5f99cf76816138940679405722eab097 100644

--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_response_info_rpc_server.cc

+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_response_info_rpc_server.cc

@@ -1,6 +1,6 @@

-// Use of this source code is governed by a BSD-style license that can

-// be found in the LICENSE file.

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

// SRPC-abstraction wrappers around PPB_URLResponseInfo functions.

@@ -27,10 +27,9 @@ void PpbURLResponseInfoRpcServer::PPB_URLResponseInfo_IsURLResponseInfo(

PP_Bool pp_success =

PPBURLResponseInfoInterface()->IsURLResponseInfo(resource);

- DebugPrintf("PPB_URLResponseInfo::IsURLResponseInfo: pp_success=%d\n",

- pp_success);

- *success = (pp_success == PP_TRUE);

+ *success = PP_ToBool(pp_success);

+ DebugPrintf("PPB_URLResponseInfo::IsURLResponseInfo: success=%d\n",

+ *success);

rpc->result = NACL_SRPC_RESULT_OK;

}

@@ -66,7 +65,7 @@ void PpbURLResponseInfoRpcServer::PPB_URLResponseInfo_GetBodyAsFileRef(

rpc->result = NACL_SRPC_RESULT_APP_ERROR;

*file_ref = PPBURLResponseInfoInterface()->GetBodyAsFileRef(response);

- DebugPrintf("PPB_URLResponseInfo::GetBodyAsFileRef: file_ref="NACL_PRIu32"\n",

+ DebugPrintf("PPB_URLResponseInfo::GetBodyAsFileRef: file_ref="NACL_PRId32"\n",

*file_ref);

rpc->result = NACL_SRPC_RESULT_OK;