ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_input_event_rpc_server.cc - Issue 9253011: Pepper SRPC proxy style and type nits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_input_event_rpc_server.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_image_data_rpc_server.cc ('k') | ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_instance_rpc_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_input_event_rpc_server.cc

diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_input_event_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_input_event_rpc_server.cc

index d8b5230468f017f1a0cea513c3749ed0ba9fddb2..a2db095f8920fc27670ab45b963bbee7644368d8 100644

--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_input_event_rpc_server.cc

+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_input_event_rpc_server.cc

@@ -1,4 +1,4 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

@@ -27,7 +27,7 @@ void PpbInputEventRpcServer::PPB_InputEvent_RequestInputEvents(

NaClSrpcClosureRunner runner(done);

rpc->result = NACL_SRPC_RESULT_APP_ERROR;

*success = PP_ERROR_FAILED;

- DebugPrintf("PPB_InputEvent::RequestInputEvents: instance=%"NACL_PRIu32", "

+ DebugPrintf("PPB_InputEvent::RequestInputEvents: instance=%"NACL_PRId32", "

"event_classes=%"NACL_PRIu32", filtering=%"NACL_PRId32"\n",

instance, static_cast<uint32_t>(event_classes), filtering);

const PPB_InputEvent* input_event_if = ppapi_proxy::PPBInputEventInterface();

@@ -58,7 +58,7 @@ void PpbInputEventRpcServer::PPB_InputEvent_ClearInputEventRequest(

int32_t event_classes) {

NaClSrpcClosureRunner runner(done);

rpc->result = NACL_SRPC_RESULT_APP_ERROR;

- DebugPrintf("PPB_InputEvent::ClearInputEventRequest: instance=%"NACL_PRIu32

+ DebugPrintf("PPB_InputEvent::ClearInputEventRequest: instance=%"NACL_PRId32

", event_classes=%"NACL_PRIu32"\n",

instance, static_cast<uint32_t>(event_classes));

const PPB_InputEvent* input_event_if = ppapi_proxy::PPBInputEventInterface();

@@ -178,10 +178,9 @@ void PpbInputEventRpcServer::PPB_InputEvent_CreateWheelInputEvent(

static_cast<uint32_t>(modifiers),

&wheel_delta,

&wheel_ticks,

- static_cast<PP_Bool>(scroll_by_page));

+ PP_FromBool(scroll_by_page));

DebugPrintf("PPB_InputEvent::CreateWheelInputEvent: resource_id="

"%"NACL_PRId32"\n",

*resource_id);

rpc->result = NACL_SRPC_RESULT_OK;

}