Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc
diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc
index 1c5bfc4f610df239d864f634d5c4292d1f8a62fd..ebb361c715f4c497260392d59de4dedf3f18fcae 100644
--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc
+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_url_request_info_rpc_server.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
@@ -27,7 +27,7 @@ void PpbURLRequestInfoRpcServer::PPB_URLRequestInfo_Create(
rpc->result = NACL_SRPC_RESULT_APP_ERROR;
*resource = PPBURLRequestInfoInterface()->Create(instance);
- DebugPrintf("PPB_URLRequestInfo::Create: resource=%"NACL_PRIu32"\n",
+ DebugPrintf("PPB_URLRequestInfo::Create: resource=%"NACL_PRId32"\n",
*resource);
rpc->result = NACL_SRPC_RESULT_OK;
@@ -44,9 +44,8 @@ void PpbURLRequestInfoRpcServer::PPB_URLRequestInfo_IsURLRequestInfo(
rpc->result = NACL_SRPC_RESULT_APP_ERROR;
PP_Bool pp_success = PPBURLRequestInfoInterface()->IsURLRequestInfo(resource);
- DebugPrintf("PPB_URLRequestInfo::IsURLRequestInfo: success=%d\n", pp_success);
-
- *success = (pp_success == PP_TRUE);
+ *success = PP_ToBool(pp_success);
+ DebugPrintf("PPB_URLRequestInfo::IsURLRequestInfo: success=%d\n", *success);
rpc->result = NACL_SRPC_RESULT_OK;
}
@@ -68,9 +67,8 @@ void PpbURLRequestInfoRpcServer::PPB_URLRequestInfo_SetProperty(
PP_Bool pp_success = PPBURLRequestInfoInterface()->SetProperty(
request, static_cast<PP_URLRequestProperty>(property), value);
- DebugPrintf("PPB_URLRequestInfo::SetProperty: pp_success=%d\n", pp_success);
-
- *success = (pp_success == PP_TRUE);
+ *success = PP_ToBool(pp_success);
+ DebugPrintf("PPB_URLRequestInfo::SetProperty: success=%d\n", *success);
rpc->result = NACL_SRPC_RESULT_OK;
}
@@ -89,10 +87,9 @@ void PpbURLRequestInfoRpcServer::PPB_URLRequestInfo_AppendDataToBody(
request,
static_cast<const char*>(data_bytes),
static_cast<uint32_t>(data_size));
- DebugPrintf("PPB_URLRequestInfo::AppendDataToBody: pp_success=%d\n",
- pp_success);
-
- *success = (pp_success == PP_TRUE);
+ *success = PP_ToBool(pp_success);
+ DebugPrintf("PPB_URLRequestInfo::AppendDataToBody: success=%d\n",
+ *success);
rpc->result = NACL_SRPC_RESULT_OK;
}
@@ -116,9 +113,8 @@ void PpbURLRequestInfoRpcServer::PPB_URLRequestInfo_AppendFileToBody(
start_offset,
number_of_bytes,
static_cast<PP_Time>(expected_last_modified_time));
+ *success = PP_ToBool(pp_success);
DebugPrintf("PPB_URLRequestInfo::AppendFileToBody: pp_success=%d\n",
- pp_success);
-
- *success = (pp_success == PP_TRUE);
+ *success);
rpc->result = NACL_SRPC_RESULT_OK;
}

Powered by Google App Engine
This is Rietveld 408576698