ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_file_system_rpc_server.cc - Issue 9253011: Pepper SRPC proxy style and type nits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_file_system_rpc_server.cc

Issue 9253011: Pepper SRPC proxy style and type nits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad license to pass presubmit check Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_file_ref_rpc_server.cc ('k') | ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_find_rpc_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_file_system_rpc_server.cc

diff --git a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_file_system_rpc_server.cc b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_file_system_rpc_server.cc

index c8f22ea18dcf4bb2bd41ac91aba060bb3b220086..8ef2393c3d26ac0e8839234a49263a49904e496f 100644

--- a/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_file_system_rpc_server.cc

+++ b/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_file_system_rpc_server.cc

@@ -1,4 +1,4 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

@@ -26,7 +26,7 @@ void PpbFileSystemRpcServer::PPB_FileSystem_Create(

*resource = PPBFileSystemInterface()->Create(

instance,

static_cast<PP_FileSystemType>(file_system_type));

- DebugPrintf("PPB_FileSystem::Create: resource=%"NACL_PRIu32"\n",

+ DebugPrintf("PPB_FileSystem::Create: resource=%"NACL_PRId32"\n",

*resource);

rpc->result = NACL_SRPC_RESULT_OK;

@@ -42,7 +42,7 @@ void PpbFileSystemRpcServer::PPB_FileSystem_IsFileSystem(

*success = PPBFileSystemInterface()->IsFileSystem(resource);

- DebugPrintf("PPB_FileSystem::IsFileSystem: resource=%"NACL_PRIu32"\n",

+ DebugPrintf("PPB_FileSystem::IsFileSystem: resource=%"NACL_PRId32"\n",

resource);

rpc->result = NACL_SRPC_RESULT_OK;

}

@@ -57,7 +57,7 @@ void PpbFileSystemRpcServer::PPB_FileSystem_Open(

NaClSrpcClosureRunner runner(done);

rpc->result = NACL_SRPC_RESULT_APP_ERROR;

- DebugPrintf("PPB_FileSystem::Open: file_system=%"NACL_PRIu32"\n",

+ DebugPrintf("PPB_FileSystem::Open: file_system=%"NACL_PRId32"\n",

file_system);

PP_CompletionCallback remote_callback = MakeRemoteCompletionCallback(

@@ -84,7 +84,7 @@ void PpbFileSystemRpcServer::PPB_FileSystem_GetType(

int32_t* type) {

NaClSrpcClosureRunner runner(done);

rpc->result = NACL_SRPC_RESULT_APP_ERROR;

- DebugPrintf("PPB_FileSystem::GetType: file_system=%"NACL_PRIu32"\n",

+ DebugPrintf("PPB_FileSystem::GetType: file_system=%"NACL_PRId32"\n",

file_system);

*type = PPBFileSystemInterface()->GetType(file_system);