[Clean up] Clean up some methods in PasswordManagerClient

[Clean up] Clean up some methods in PasswordManagerClient

This is a cleanup change in preparation for [http://crbug.com/455830], where
some methods are maked as const and some of the non-pure virtual methods will
be defined into the cc file.

BUG=455830
Committed: https://crrev.com/da31c6958b800b4ee15122af4ef3080a0f09713f
Cr-Commit-Position: refs/heads/master@{#316438}

[jinlong.zhai, 2015-02-06 07:14:04]

jinlong.zhai@samsung.com changed reviewers:
+ isherman@chromium.org, mkwst@chromium.org, vabr@chromium.org

[jinlong.zhai, 2015-02-06 07:14:05]

Please help to look at this patch. 
Thanks!

[vabr (Chromium), 2015-02-06 11:34:56]

Before looking at the patch set itself, two questions/comments:

(1) You don't seem to be listed in AUTHORS, and neither do I see you among the
CLA signers. Could you please check out the steps from
http://www.chromium.org/developers/contributing-code/external-contributor-che...
and fix that?

(2) Please leave a comment on the bugtracker that you have a CL for this bug.
Otherwise somebody working on it silently as you do might duplicate your work.

Thanks,
Vaclav

[vabr (Chromium), 2015-02-06 11:39:52]

The code itself looks good. I'll wait until the issue with the CLA signing and
AUTHORS is solved, and then will approve this CL.

Cheers,
Vaclav

[Ilya Sherman, 2015-02-06 23:43:44]

isherman@chromium.org changed reviewers:
- isherman@chromium.org

[jinlong.zhai, 2015-02-09 03:40:26]

hi Vaclav:
For question (1), my first patch with AUTHOR file
(https://codereview.chromium.org/889313003/) have been approved.
So I think I have already listed in AUTHOR file.

For question (1), I have signed a comment on the bugtracker.

Please help to check.
Thanks,
Jinlong

[jinlong.zhai, 2015-02-09 03:40:48]

On 2015/02/09 03:40:26, jinlong.zhai wrote:
> hi Vaclav:
> For question (1), my first patch with AUTHOR file
> (https://codereview.chromium.org/889313003/) have been approved.
> So I think I have already listed in AUTHOR file.
> 
> For question (2), I have signed a comment on the bugtracker.
> 
> Please help to check.
> Thanks,
> Jinlong

[vabr (Chromium), 2015-02-09 08:47:42]

On 2015/02/09 03:40:48, jinlong.zhai wrote:
> On 2015/02/09 03:40:26, jinlong.zhai wrote:
> > hi Vaclav:
> > For question (1), my first patch with AUTHOR file
> > (https://codereview.chromium.org/889313003/) have been approved.
> > So I think I have already listed in AUTHOR file.
> > 
> > For question (2), I have signed a comment on the bugtracker.
> > 
> > Please help to check.
> > Thanks,
> > Jinlong

Hi Jinlong,

Thanks for your answer. I now confirm seeing your e-mail address in the AUTHORS
file.

However, I still cannot see your signature in the SLA records. I'm not sure what
you mean by "signed a comment on the bugtracker", but the external contributor
checklist says:
"ask the person to sign the CLA: 
https://code.google.com/legal/individual-cla-v1.0.html (individual) or 
https://code.google.com/legal/corporate-cla-v1.0.html (corporate)"
Did you sign one of these? (And if yes, which one?)

Thanks,
Vaclav

[jinlong.zhai, 2015-02-11 02:28:53]

On 2015/02/09 08:47:42, vabr (Chromium) wrote:
> On 2015/02/09 03:40:48, jinlong.zhai wrote:
> > On 2015/02/09 03:40:26, jinlong.zhai wrote:
> > > hi Vaclav:
> > > For question (1), my first patch with AUTHOR file
> > > (https://codereview.chromium.org/889313003/) have been approved.
> > > So I think I have already listed in AUTHOR file.
> > > 
> > > For question (2), I have signed a comment on the bugtracker.
> > > 
> > > Please help to check.
> > > Thanks,
> > > Jinlong
> 
> Hi Jinlong,
> 
> Thanks for your answer. I now confirm seeing your e-mail address in the
AUTHORS
> file.
> 
> However, I still cannot see your signature in the SLA records. I'm not sure
what
> you mean by "signed a comment on the bugtracker", but the external contributor
> checklist says:
> "ask the person to sign the CLA: 
> https://code.google.com/legal/individual-cla-v1.0.html (individual) or 
> https://code.google.com/legal/corporate-cla-v1.0.html (corporate)"
> Did you sign one of these? (And if yes, which one?)
> 
> Thanks,
> Vaclav

Hi Vaclav,

I think I have been in the CLA records:
https://groups.google.com/forum/#!members/samsung-chromium-dev

Please help to check.

Thanks,
Jinlong

[vabr (Chromium), 2015-02-11 13:36:21]

Hi Jinlong,

I've been told that you were added to the Samsung group of the CLA signers. I
guess I misunderstood the tool for viewing the signatures, sorry for the delay
it caused.

Your change LGTM. Feel free to go ahead and land it.

Cheers,
Vaclav

[jinlong.zhai, 2015-02-15 02:10:58]

jinlong.zhai@samsung.com changed reviewers:
+ albertb@chromium.org
- mkwst@chromium.org

[jinlong.zhai, 2015-02-15 02:10:58]

-Mike West  +albertb
PTAK, thanks!

[jinlong.zhai, 2015-02-16 01:52:35]

The CQ bit was checked by jinlong.zhai@samsung.com

[commit-bot: I haz the power, 2015-02-16 01:52:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900223005/1

[commit-bot: I haz the power, 2015-02-16 01:59:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-16 01:59:51]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jinlong.zhai, 2015-02-16 05:43:35]

New patchsets have been uploaded after l-g-t-m from vabr@chromium.org

[jinlong.zhai, 2015-02-16 05:43:59]

The CQ bit was checked by jinlong.zhai@samsung.com

[commit-bot: I haz the power, 2015-02-16 05:44:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900223005/20001

[commit-bot: I haz the power, 2015-02-16 05:51:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-16 05:51:10]

Try jobs failed on following builders:
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[jinlong.zhai, 2015-02-16 06:02:53]

The CQ bit was checked by jinlong.zhai@samsung.com

[commit-bot: I haz the power, 2015-02-16 06:03:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900223005/40001

[commit-bot: I haz the power, 2015-02-16 06:12:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-16 06:12:12]

Try jobs failed on following builders:
  ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)

[jinlong.zhai, 2015-02-16 06:20:52]

The CQ bit was checked by jinlong.zhai@samsung.com

[commit-bot: I haz the power, 2015-02-16 06:21:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900223005/60001

[commit-bot: I haz the power, 2015-02-16 06:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-16 06:29:23]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)

[jinlong.zhai, 2015-02-16 06:42:57]

The CQ bit was checked by jinlong.zhai@samsung.com

[commit-bot: I haz the power, 2015-02-16 06:43:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900223005/80001

[commit-bot: I haz the power, 2015-02-16 06:58:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-16 06:58:14]

Try jobs failed on following builders:
  android_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  android_rel_tests_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_rel_tes...)

[jinlong.zhai, 2015-02-16 07:07:51]

The CQ bit was checked by jinlong.zhai@samsung.com

[commit-bot: I haz the power, 2015-02-16 07:08:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/900223005/100001

[commit-bot: I haz the power, 2015-02-16 07:57:38]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-16 07:58:46]

Patchset 6 (id:??) landed as
https://crrev.com/da31c6958b800b4ee15122af4ef3080a0f09713f
Cr-Commit-Position: refs/heads/master@{#316438}

[vabr (Chromium), 2015-02-23 09:39:10]

Patch set https://codereview.chromium.org/900223005/#ps100001 still LGTM.
Thanks,
Vaclav