Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Side by Side Diff: components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/content/browser/credential_manager_dispatc her.h" 5 #include "components/password_manager/content/browser/credential_manager_dispatc her.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/prefs/pref_registry_simple.h" 9 #include "base/prefs/pref_registry_simple.h"
10 #include "base/prefs/testing_pref_service.h" 10 #include "base/prefs/testing_pref_service.h"
(...skipping 27 matching lines...) Expand all
38 TestPasswordManagerClient(password_manager::PasswordStore* store) 38 TestPasswordManagerClient(password_manager::PasswordStore* store)
39 : did_prompt_user_to_save_(false), 39 : did_prompt_user_to_save_(false),
40 did_prompt_user_to_choose_(false), 40 did_prompt_user_to_choose_(false),
41 is_off_the_record_(false), 41 is_off_the_record_(false),
42 store_(store) { 42 store_(store) {
43 prefs_.registry()->RegisterBooleanPref( 43 prefs_.registry()->RegisterBooleanPref(
44 password_manager::prefs::kPasswordManagerAutoSignin, true); 44 password_manager::prefs::kPasswordManagerAutoSignin, true);
45 } 45 }
46 ~TestPasswordManagerClient() override {} 46 ~TestPasswordManagerClient() override {}
47 47
48 password_manager::PasswordStore* GetPasswordStore() override { 48 password_manager::PasswordStore* GetPasswordStore() const override {
49 return store_; 49 return store_;
50 } 50 }
51 51
52 PrefService* GetPrefs() override { return &prefs_; } 52 PrefService* GetPrefs() override { return &prefs_; }
53 53
54 bool PromptUserToSavePassword( 54 bool PromptUserToSavePassword(
55 scoped_ptr<password_manager::PasswordFormManager> manager) override { 55 scoped_ptr<password_manager::PasswordFormManager> manager) override {
56 did_prompt_user_to_save_ = true; 56 did_prompt_user_to_save_ = true;
57 manager_.reset(manager.release()); 57 manager_.reset(manager.release());
58 return true; 58 return true;
(...skipping 10 matching lines...) Expand all
69 password_manager::CredentialInfo info( 69 password_manager::CredentialInfo info(
70 local_forms.empty() ? *federated_forms[0] : *local_forms[0], 70 local_forms.empty() ? *federated_forms[0] : *local_forms[0],
71 local_forms.empty() 71 local_forms.empty()
72 ? password_manager::CredentialType::CREDENTIAL_TYPE_FEDERATED 72 ? password_manager::CredentialType::CREDENTIAL_TYPE_FEDERATED
73 : password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL); 73 : password_manager::CredentialType::CREDENTIAL_TYPE_LOCAL);
74 base::MessageLoop::current()->PostTask(FROM_HERE, 74 base::MessageLoop::current()->PostTask(FROM_HERE,
75 base::Bind(callback, info)); 75 base::Bind(callback, info));
76 return true; 76 return true;
77 } 77 }
78 78
79 bool IsOffTheRecord() override { return is_off_the_record_; } 79 bool IsOffTheRecord() const override { return is_off_the_record_; }
80 80
81 bool did_prompt_user_to_save() const { return did_prompt_user_to_save_; } 81 bool did_prompt_user_to_save() const { return did_prompt_user_to_save_; }
82 bool did_prompt_user_to_choose() const { return did_prompt_user_to_choose_; } 82 bool did_prompt_user_to_choose() const { return did_prompt_user_to_choose_; }
83 83
84 password_manager::PasswordFormManager* pending_manager() const { 84 password_manager::PasswordFormManager* pending_manager() const {
85 return manager_.get(); 85 return manager_.get();
86 } 86 }
87 87
88 void set_off_the_record(bool off_the_record) { 88 void set_off_the_record(bool off_the_record) {
89 is_off_the_record_ = off_the_record; 89 is_off_the_record_ = off_the_record;
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
541 const IPC::Message* message = 541 const IPC::Message* message =
542 process()->sink().GetFirstMessageMatching(kMsgID); 542 process()->sink().GetFirstMessageMatching(kMsgID);
543 ASSERT_TRUE(message); 543 ASSERT_TRUE(message);
544 CredentialManagerMsg_SendCredential::Param param; 544 CredentialManagerMsg_SendCredential::Param param;
545 CredentialManagerMsg_SendCredential::Read(message, &param); 545 CredentialManagerMsg_SendCredential::Read(message, &param);
546 EXPECT_EQ(CredentialType::CREDENTIAL_TYPE_EMPTY, get<1>(param).type); 546 EXPECT_EQ(CredentialType::CREDENTIAL_TYPE_EMPTY, get<1>(param).type);
547 EXPECT_FALSE(client_->did_prompt_user_to_choose()); 547 EXPECT_FALSE(client_->did_prompt_user_to_choose());
548 } 548 }
549 549
550 } // namespace password_manager 550 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698