Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/scoped_ptr.h" 5 #include "base/memory/scoped_ptr.h"
6 #include "base/message_loop/message_loop.h" 6 #include "base/message_loop/message_loop.h"
7 #include "base/prefs/pref_registry_simple.h" 7 #include "base/prefs/pref_registry_simple.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/prefs/testing_pref_service.h" 9 #include "base/prefs/testing_pref_service.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 true); 95 true);
96 } 96 }
97 97
98 bool ShouldFilterAutofillResult(const autofill::PasswordForm& form) override { 98 bool ShouldFilterAutofillResult(const autofill::PasswordForm& form) override {
99 if (form == form_to_filter_) 99 if (form == form_to_filter_)
100 return true; 100 return true;
101 return false; 101 return false;
102 } 102 }
103 103
104 PrefService* GetPrefs() override { return &prefs_; } 104 PrefService* GetPrefs() override { return &prefs_; }
105 PasswordStore* GetPasswordStore() override { return password_store_; } 105 PasswordStore* GetPasswordStore() const override { return password_store_; }
106 106
107 void SetFormToFilter(const autofill::PasswordForm& form) { 107 void SetFormToFilter(const autofill::PasswordForm& form) {
108 form_to_filter_ = form; 108 form_to_filter_ = form;
109 } 109 }
110 110
111 MockPasswordManagerDriver* mock_driver() { return driver_.get(); } 111 MockPasswordManagerDriver* mock_driver() { return driver_.get(); }
112 112
113 base::WeakPtr<PasswordManagerDriver> driver() { return driver_->AsWeakPtr(); } 113 base::WeakPtr<PasswordManagerDriver> driver() { return driver_->AsWeakPtr(); }
114 114
115 autofill::AutofillManager* GetAutofillManagerForMainFrame() override { 115 autofill::AutofillManager* GetAutofillManagerForMainFrame() override {
(...skipping 1251 matching lines...) Expand 10 before | Expand all | Expand 10 after
1367 form_manager.OnGetPasswordStoreResults(simulated_results.Pass()); 1367 form_manager.OnGetPasswordStoreResults(simulated_results.Pass());
1368 EXPECT_EQ(1u, form_manager.best_matches().size()); 1368 EXPECT_EQ(1u, form_manager.best_matches().size());
1369 EXPECT_EQ(form_manager.preferred_match(), 1369 EXPECT_EQ(form_manager.preferred_match(),
1370 form_manager.best_matches().begin()->second); 1370 form_manager.best_matches().begin()->second);
1371 // Make sure to access all fields of preferred_match; this way if it was 1371 // Make sure to access all fields of preferred_match; this way if it was
1372 // deleted, ASAN might notice it. 1372 // deleted, ASAN might notice it.
1373 PasswordForm dummy(*form_manager.preferred_match()); 1373 PasswordForm dummy(*form_manager.preferred_match());
1374 } 1374 }
1375 1375
1376 } // namespace password_manager 1376 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698