Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index 6b7ea1553b5a10f165332376ed8b15cf2ef3eb8a..daa2dd6892c30da4235fce3bfc4aec0aaa3de79d 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -72,7 +72,7 @@ class PasswordManagerClient {
// Called when all autofill results have been computed. Client can use
// this signal to report statistics. Default implementation is a noop.
- virtual void AutofillResultsComputed() {}
+ virtual void AutofillResultsComputed();
// Informs the embedder of a password form that can be saved if the user
// allows it. The embedder is not required to prompt the user if it decides
@@ -101,30 +101,30 @@ class PasswordManagerClient {
// save this to the PasswordStore, for example. Default implementation is a
// noop.
virtual void PasswordWasAutofilled(
- const autofill::PasswordFormMap& best_matches) const {}
+ const autofill::PasswordFormMap& best_matches) const;
// Called when password autofill is blocked by the blacklist. |best_matches|
// contains the PasswordForm that flags the current site as being on the
// blacklist. The client may choose to remove this from the PasswordStore in
// order to unblacklist a site, for example. Default implementation is a noop.
virtual void PasswordAutofillWasBlocked(
- const autofill::PasswordFormMap& best_matches) const {}
+ const autofill::PasswordFormMap& best_matches) const;
// Gets prefs associated with this embedder.
virtual PrefService* GetPrefs() = 0;
// Returns the PasswordStore associated with this instance.
- virtual PasswordStore* GetPasswordStore() = 0;
+ virtual PasswordStore* GetPasswordStore() const = 0;
// Returns the probability that the experiment identified by |experiment_name|
// should be enabled. The default implementation returns 0.
virtual base::FieldTrial::Probability GetProbabilityForExperiment(
- const std::string& experiment_name);
+ const std::string& experiment_name) const;
// Returns true if password sync is enabled in the embedder. Return value for
// custom passphrase users depends on |state|. The default implementation
// always returns false.
- virtual bool IsPasswordSyncEnabled(CustomPassphraseState state);
+ virtual bool IsPasswordSyncEnabled(CustomPassphraseState state) const;
// Only for clients which registered with a LogRouter: If called with
// |router_can_be_used| set to false, the client may no longer use the
@@ -149,10 +149,10 @@ class PasswordManagerClient {
// Returns whether any SSL certificate errors were encountered as a result of
// the last page load.
- virtual bool DidLastPageLoadEncounterSSLErrors();
+ virtual bool DidLastPageLoadEncounterSSLErrors() const;
// If this browsing session should not be persisted.
- virtual bool IsOffTheRecord();
+ virtual bool IsOffTheRecord() const;
// Returns the PasswordManager associated with this client.
virtual PasswordManager* GetPasswordManager();
@@ -161,7 +161,7 @@ class PasswordManagerClient {
virtual autofill::AutofillManager* GetAutofillManagerForMainFrame();
// Returns the main frame URL.
- virtual const GURL& GetMainFrameURL();
+ virtual const GURL& GetMainFrameURL() const;
private:
DISALLOW_COPY_AND_ASSIGN(PasswordManagerClient);

Powered by Google App Engine
This is Rietveld 408576698