Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/password_manager_client.h" 5 #include "components/password_manager/core/browser/password_manager_client.h"
6 6
7 namespace password_manager { 7 namespace password_manager {
8 8
9 bool PasswordManagerClient::IsAutomaticPasswordSavingEnabled() const { 9 bool PasswordManagerClient::IsAutomaticPasswordSavingEnabled() const {
10 return false; 10 return false;
11 } 11 }
12 12
13 bool PasswordManagerClient::IsPasswordManagerEnabledForCurrentPage() const { 13 bool PasswordManagerClient::IsPasswordManagerEnabledForCurrentPage() const {
14 return true; 14 return true;
15 } 15 }
16 16
17 base::FieldTrial::Probability 17 base::FieldTrial::Probability
18 PasswordManagerClient::GetProbabilityForExperiment( 18 PasswordManagerClient::GetProbabilityForExperiment(
19 const std::string& experiment_name) { 19 const std::string& experiment_name) const {
20 return 0; 20 return 0;
21 } 21 }
22 22
23 void PasswordManagerClient::AskUserAndMaybeReportURL(const GURL& url) const { 23 void PasswordManagerClient::AskUserAndMaybeReportURL(const GURL& url) const {
24 } 24 }
25 25
26 bool PasswordManagerClient::IsPasswordSyncEnabled(CustomPassphraseState state) { 26 void PasswordManagerClient::AutofillResultsComputed() {
27 }
28
29 void PasswordManagerClient::PasswordWasAutofilled(
30 const autofill::PasswordFormMap& best_matches) const {
31 }
32
33 void PasswordManagerClient::PasswordAutofillWasBlocked(
34 const autofill::PasswordFormMap& best_matches) const {
35 }
36
37 bool PasswordManagerClient::IsPasswordSyncEnabled(
38 CustomPassphraseState state) const {
27 return false; 39 return false;
28 } 40 }
29 41
30 void PasswordManagerClient::OnLogRouterAvailabilityChanged( 42 void PasswordManagerClient::OnLogRouterAvailabilityChanged(
31 bool router_can_be_used) { 43 bool router_can_be_used) {
32 } 44 }
33 45
34 void PasswordManagerClient::LogSavePasswordProgress( 46 void PasswordManagerClient::LogSavePasswordProgress(
35 const std::string& text) const { 47 const std::string& text) const {
36 } 48 }
(...skipping 19 matching lines...) Expand all
56 // implemented, never prompt the user for keychain access. 68 // implemented, never prompt the user for keychain access.
57 // Effectively, this means that passwords stored by Chrome still work, 69 // Effectively, this means that passwords stored by Chrome still work,
58 // since Chrome can access those without a prompt, but passwords stored by 70 // since Chrome can access those without a prompt, but passwords stored by
59 // Safari, Firefox, or Chrome Canary will not work. Note that the latest 71 // Safari, Firefox, or Chrome Canary will not work. Note that the latest
60 // build of Safari and Firefox don't create keychain items with the 72 // build of Safari and Firefox don't create keychain items with the
61 // relevant tags anyways (7/11/2014). 73 // relevant tags anyways (7/11/2014).
62 // http://crbug.com/178358 74 // http://crbug.com/178358
63 return PasswordStore::DISALLOW_PROMPT; 75 return PasswordStore::DISALLOW_PROMPT;
64 } 76 }
65 77
66 bool PasswordManagerClient::DidLastPageLoadEncounterSSLErrors() { 78 bool PasswordManagerClient::DidLastPageLoadEncounterSSLErrors() const {
67 return false; 79 return false;
68 } 80 }
69 81
70 bool PasswordManagerClient::IsOffTheRecord() { 82 bool PasswordManagerClient::IsOffTheRecord() const {
71 return false; 83 return false;
72 } 84 }
73 85
74 PasswordManager* PasswordManagerClient::GetPasswordManager() { 86 PasswordManager* PasswordManagerClient::GetPasswordManager() {
75 return nullptr; 87 return nullptr;
76 } 88 }
77 89
78 autofill::AutofillManager* 90 autofill::AutofillManager*
79 PasswordManagerClient::GetAutofillManagerForMainFrame() { 91 PasswordManagerClient::GetAutofillManagerForMainFrame() {
80 return nullptr; 92 return nullptr;
81 } 93 }
82 94
83 const GURL& PasswordManagerClient::GetMainFrameURL() { 95 const GURL& PasswordManagerClient::GetMainFrameURL() const {
84 return GURL::EmptyGURL(); 96 return GURL::EmptyGURL();
85 } 97 }
86 98
87 } // namespace password_manager 99 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698