Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/password_manager.h" 5 #include "components/password_manager/core/browser/password_manager.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 22 matching lines...) Expand all
33 33
34 namespace password_manager { 34 namespace password_manager {
35 35
36 namespace { 36 namespace {
37 37
38 class MockPasswordManagerClient : public StubPasswordManagerClient { 38 class MockPasswordManagerClient : public StubPasswordManagerClient {
39 public: 39 public:
40 MOCK_CONST_METHOD0(IsPasswordManagerEnabledForCurrentPage, bool()); 40 MOCK_CONST_METHOD0(IsPasswordManagerEnabledForCurrentPage, bool());
41 MOCK_CONST_METHOD2(IsSyncAccountCredential, 41 MOCK_CONST_METHOD2(IsSyncAccountCredential,
42 bool(const std::string&, const std::string&)); 42 bool(const std::string&, const std::string&));
43 MOCK_CONST_METHOD0(GetPasswordStore, PasswordStore*());
44 MOCK_CONST_METHOD0(DidLastPageLoadEncounterSSLErrors, bool());
43 MOCK_METHOD1(PromptUserToSavePasswordPtr, void(PasswordFormManager*)); 45 MOCK_METHOD1(PromptUserToSavePasswordPtr, void(PasswordFormManager*));
44 MOCK_METHOD1(AutomaticPasswordSavePtr, void(PasswordFormManager*)); 46 MOCK_METHOD1(AutomaticPasswordSavePtr, void(PasswordFormManager*));
45 MOCK_METHOD0(GetPasswordStore, PasswordStore*());
46 MOCK_METHOD0(GetPrefs, PrefService*()); 47 MOCK_METHOD0(GetPrefs, PrefService*());
47 MOCK_METHOD0(GetDriver, PasswordManagerDriver*()); 48 MOCK_METHOD0(GetDriver, PasswordManagerDriver*());
48 MOCK_METHOD0(DidLastPageLoadEncounterSSLErrors, bool());
49 49
50 // Workaround for scoped_ptr<> lacking a copy constructor. 50 // Workaround for scoped_ptr<> lacking a copy constructor.
51 virtual bool PromptUserToSavePassword( 51 virtual bool PromptUserToSavePassword(
52 scoped_ptr<PasswordFormManager> manager) override { 52 scoped_ptr<PasswordFormManager> manager) override {
53 PromptUserToSavePasswordPtr(manager.release()); 53 PromptUserToSavePasswordPtr(manager.release());
54 return false; 54 return false;
55 } 55 }
56 virtual void AutomaticPasswordSave( 56 virtual void AutomaticPasswordSave(
57 scoped_ptr<PasswordFormManager> manager) override { 57 scoped_ptr<PasswordFormManager> manager) override {
58 AutomaticPasswordSavePtr(manager.release()); 58 AutomaticPasswordSavePtr(manager.release());
(...skipping 834 matching lines...) Expand 10 before | Expand all | Expand 10 after
893 manager()->ProvisionallySavePassword(form); 893 manager()->ProvisionallySavePassword(form);
894 894
895 scoped_ptr<PasswordFormManager> form_to_save; 895 scoped_ptr<PasswordFormManager> form_to_save;
896 EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_)) 896 EXPECT_CALL(client_, PromptUserToSavePasswordPtr(_))
897 .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save))); 897 .WillOnce(WithArg<0>(SaveToScopedPtr(&form_to_save)));
898 898
899 manager()->OnInPageNavigation(&driver_, form); 899 manager()->OnInPageNavigation(&driver_, form);
900 } 900 }
901 901
902 } // namespace password_manager 902 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698