components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc - Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

diff --git a/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

index 39e07756367fec1c20357eb03c32f762e006dd2d..e9dc5eda71b6082bfa29b5c8f93d94b5b11bced4 100644

--- a/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

+++ b/components/password_manager/content/browser/credential_manager_dispatcher_unittest.cc

@@ -45,7 +45,7 @@ class TestPasswordManagerClient

}

~TestPasswordManagerClient() override {}

- password_manager::PasswordStore* GetPasswordStore() override {

+ password_manager::PasswordStore* GetPasswordStore() const override {

return store_;

}

@@ -76,7 +76,7 @@ class TestPasswordManagerClient

return true;

}

- bool IsOffTheRecord() override { return is_off_the_record_; }

+ bool IsOffTheRecord() const override { return is_off_the_record_; }

bool did_prompt_user_to_save() const { return did_prompt_user_to_save_; }

bool did_prompt_user_to_choose() const { return did_prompt_user_to_choose_; }