components/password_manager/core/browser/password_manager_unittest.cc - Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_client.cc ('k') | components/password_manager/core/browser/stub_password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc

index c6cce42a7b71c5c2a308025facc1bfb9e74052b1..91c0e04194f8fee198c4e782860ff245d1b45f7b 100644

--- a/components/password_manager/core/browser/password_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_unittest.cc

@@ -40,12 +40,12 @@ class MockPasswordManagerClient : public StubPasswordManagerClient {

MOCK_CONST_METHOD0(IsPasswordManagerEnabledForCurrentPage, bool());

MOCK_CONST_METHOD2(IsSyncAccountCredential,

bool(const std::string&, const std::string&));

+ MOCK_CONST_METHOD0(GetPasswordStore, PasswordStore*());

+ MOCK_CONST_METHOD0(DidLastPageLoadEncounterSSLErrors, bool());

MOCK_METHOD1(PromptUserToSavePasswordPtr, void(PasswordFormManager*));

MOCK_METHOD1(AutomaticPasswordSavePtr, void(PasswordFormManager*));

- MOCK_METHOD0(GetPasswordStore, PasswordStore*());

MOCK_METHOD0(GetPrefs, PrefService*());

MOCK_METHOD0(GetDriver, PasswordManagerDriver*());

- MOCK_METHOD0(DidLastPageLoadEncounterSSLErrors, bool());

// Workaround for scoped_ptr<> lacking a copy constructor.

virtual bool PromptUserToSavePassword(