components/password_manager/core/browser/password_generation_manager_unittest.cc - Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager_unittest.cc

Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | components/password_manager/core/browser/password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_generation_manager_unittest.cc b/components/password_manager/core/browser/password_generation_manager_unittest.cc

index 54b478896249c03bca118cee23653c3471249459..01bb37772e93a135f32e61ac917ff091e7ac2be5 100644

--- a/components/password_manager/core/browser/password_generation_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_generation_manager_unittest.cc

@@ -73,10 +73,10 @@ class TestPasswordManagerClient : public StubPasswordManagerClient {

~TestPasswordManagerClient() override { store_->Shutdown(); }

- bool IsOffTheRecord() override { return is_off_the_record_; }

- PasswordStore* GetPasswordStore() override { return store_.get(); }

+ bool IsOffTheRecord() const override { return is_off_the_record_; }

+ PasswordStore* GetPasswordStore() const override { return store_.get(); }

PrefService* GetPrefs() override { return prefs_.get(); }

- bool IsPasswordSyncEnabled(CustomPassphraseState state) override {

+ bool IsPasswordSyncEnabled(CustomPassphraseState state) const override {

return is_sync_enabled_;

}