[Clean up] Clean up some methods in PasswordManagerClient

components/password_manager/core/browser/password_manager_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_CLIENT_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_CLIENT_H_
 
 #include "base/callback.h"
 #include "base/memory/scoped_vector.h"
 #include "base/metrics/field_trial.h"
@@ skipping 54 matching lines @@
   virtual bool IsSyncAccountCredential(const std::string& username,
                                        const std::string& origin) const = 0;
 
   // This should be called if the password manager encounters a problem on
   // |url|. The implementation should show the "Allow to collect URL?" bubble
   // and, if the user confirms, report the |url|.
   virtual void AskUserAndMaybeReportURL(const GURL& url) const;
 
   // Called when all autofill results have been computed. Client can use
   // this signal to report statistics. Default implementation is a noop.
-  virtual void AutofillResultsComputed() {}
+  virtual void AutofillResultsComputed();
 
   // Informs the embedder of a password form that can be saved if the user
   // allows it. The embedder is not required to prompt the user if it decides
   // that this form doesn't need to be saved.
   // Returns true if the prompt was indeed displayed.
   virtual bool PromptUserToSavePassword(
       scoped_ptr<PasswordFormManager> form_to_save) = 0;
 
   // Informs the embedder of a password forms that the user should choose from.
   // Returns true if the prompt is indeed displayed. If the prompt is not
   // displayed, returns false and does not call |callback|.
   // |callback| should be invoked with the chosen form.
   virtual bool PromptUserToChooseCredentials(
       ScopedVector<autofill::PasswordForm> local_forms,
       ScopedVector<autofill::PasswordForm> federated_forms,
       const GURL& origin,
       base::Callback<void(const CredentialInfo&)> callback) = 0;
 
   // Called when a password is saved in an automated fashion. Embedder may
   // inform the user that this save has occured.
   virtual void AutomaticPasswordSave(
       scoped_ptr<PasswordFormManager> saved_form_manager) = 0;
 
   // Called when a password is autofilled. |best_matches| contains the
   // PasswordForm into which a password was filled: the client may choose to
   // save this to the PasswordStore, for example. Default implementation is a
   // noop.
   virtual void PasswordWasAutofilled(
-      const autofill::PasswordFormMap& best_matches) const {}
+      const autofill::PasswordFormMap& best_matches) const;
 
   // Called when password autofill is blocked by the blacklist. |best_matches|
   // contains the PasswordForm that flags the current site as being on the
   // blacklist. The client may choose to remove this from the PasswordStore in
   // order to unblacklist a site, for example. Default implementation is a noop.
   virtual void PasswordAutofillWasBlocked(
-      const autofill::PasswordFormMap& best_matches) const {}
+      const autofill::PasswordFormMap& best_matches) const;
 
   // Gets prefs associated with this embedder.
   virtual PrefService* GetPrefs() = 0;
 
   // Returns the PasswordStore associated with this instance.
-  virtual PasswordStore* GetPasswordStore() = 0;
+  virtual PasswordStore* GetPasswordStore() const = 0;
 
   // Returns the probability that the experiment identified by |experiment_name|
   // should be enabled. The default implementation returns 0.
   virtual base::FieldTrial::Probability GetProbabilityForExperiment(
-      const std::string& experiment_name);
+      const std::string& experiment_name) const;
 
   // Returns true if password sync is enabled in the embedder. Return value for
   // custom passphrase users depends on |state|. The default implementation
   // always returns false.
-  virtual bool IsPasswordSyncEnabled(CustomPassphraseState state);
+  virtual bool IsPasswordSyncEnabled(CustomPassphraseState state) const;
 
   // Only for clients which registered with a LogRouter: If called with
   // |router_can_be_used| set to false, the client may no longer use the
   // LogRouter. If |router_can_be_used| is true, the LogRouter can be used after
   // the return from OnLogRouterAvailabilityChanged.
   virtual void OnLogRouterAvailabilityChanged(bool router_can_be_used);
 
   // Forward |text| for display to the LogRouter (if registered with one).
   virtual void LogSavePasswordProgress(const std::string& text) const;
 
   // Returns true if logs recorded via LogSavePasswordProgress will be
   // displayed, and false otherwise.
   virtual bool IsLoggingActive() const;
 
   // Returns true if last navigation page had HTTP error i.e 5XX or 4XX
   virtual bool WasLastNavigationHTTPError() const;
 
   // Returns the authorization prompt policy to be used with the given form.
   // Only relevant on OSX.
   virtual PasswordStore::AuthorizationPromptPolicy GetAuthorizationPromptPolicy(
       const autofill::PasswordForm& form);
 
   // Returns whether any SSL certificate errors were encountered as a result of
   // the last page load.
-  virtual bool DidLastPageLoadEncounterSSLErrors();
+  virtual bool DidLastPageLoadEncounterSSLErrors() const;
 
   // If this browsing session should not be persisted.
-  virtual bool IsOffTheRecord();
+  virtual bool IsOffTheRecord() const;
 
   // Returns the PasswordManager associated with this client.
   virtual PasswordManager* GetPasswordManager();
 
   // Returns the AutofillManager for the main frame.
   virtual autofill::AutofillManager* GetAutofillManagerForMainFrame();
 
   // Returns the main frame URL.
-  virtual const GURL& GetMainFrameURL();
+  virtual const GURL& GetMainFrameURL() const;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerClient);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_MANAGER_CLIENT_H_