Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: components/password_manager/core/browser/password_manager_client.cc

Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.cc
diff --git a/components/password_manager/core/browser/password_manager_client.cc b/components/password_manager/core/browser/password_manager_client.cc
index dc711c1bea429ccc0657d1a3c3783f4f6884a9d3..7edc803697a9a1129eb7abf64f0f16dbe00a1666 100644
--- a/components/password_manager/core/browser/password_manager_client.cc
+++ b/components/password_manager/core/browser/password_manager_client.cc
@@ -16,14 +16,26 @@ bool PasswordManagerClient::IsPasswordManagerEnabledForCurrentPage() const {
base::FieldTrial::Probability
PasswordManagerClient::GetProbabilityForExperiment(
- const std::string& experiment_name) {
+ const std::string& experiment_name) const {
return 0;
}
void PasswordManagerClient::AskUserAndMaybeReportURL(const GURL& url) const {
}
-bool PasswordManagerClient::IsPasswordSyncEnabled(CustomPassphraseState state) {
+void PasswordManagerClient::AutofillResultsComputed() {
+}
+
+void PasswordManagerClient::PasswordWasAutofilled(
+ const autofill::PasswordFormMap& best_matches) const {
+}
+
+void PasswordManagerClient::PasswordAutofillWasBlocked(
+ const autofill::PasswordFormMap& best_matches) const {
+}
+
+bool PasswordManagerClient::IsPasswordSyncEnabled(
+ CustomPassphraseState state) const {
return false;
}
@@ -63,11 +75,11 @@ PasswordManagerClient::GetAuthorizationPromptPolicy(
return PasswordStore::DISALLOW_PROMPT;
}
-bool PasswordManagerClient::DidLastPageLoadEncounterSSLErrors() {
+bool PasswordManagerClient::DidLastPageLoadEncounterSSLErrors() const {
return false;
}
-bool PasswordManagerClient::IsOffTheRecord() {
+bool PasswordManagerClient::IsOffTheRecord() const {
return false;
}
@@ -80,7 +92,7 @@ PasswordManagerClient::GetAutofillManagerForMainFrame() {
return nullptr;
}
-const GURL& PasswordManagerClient::GetMainFrameURL() {
+const GURL& PasswordManagerClient::GetMainFrameURL() const {
return GURL::EmptyGURL();
}

Powered by Google App Engine
This is Rietveld 408576698