Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 900223005: [Clean up] Clean up some methods in PasswordManagerClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "components/password_manager/content/browser/content_password_manager_d river_factory.h" 10 #include "components/password_manager/content/browser/content_password_manager_d river_factory.h"
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 const GURL& origin, 58 const GURL& origin,
59 base::Callback<void(const password_manager::CredentialInfo&)> callback) 59 base::Callback<void(const password_manager::CredentialInfo&)> callback)
60 override; 60 override;
61 void AutomaticPasswordSave(scoped_ptr<password_manager::PasswordFormManager> 61 void AutomaticPasswordSave(scoped_ptr<password_manager::PasswordFormManager>
62 saved_form_manager) override; 62 saved_form_manager) override;
63 void PasswordWasAutofilled( 63 void PasswordWasAutofilled(
64 const autofill::PasswordFormMap& best_matches) const override; 64 const autofill::PasswordFormMap& best_matches) const override;
65 void PasswordAutofillWasBlocked( 65 void PasswordAutofillWasBlocked(
66 const autofill::PasswordFormMap& best_matches) const override; 66 const autofill::PasswordFormMap& best_matches) const override;
67 PrefService* GetPrefs() override; 67 PrefService* GetPrefs() override;
68 password_manager::PasswordStore* GetPasswordStore() override; 68 password_manager::PasswordStore* GetPasswordStore() const override;
69 base::FieldTrial::Probability GetProbabilityForExperiment( 69 base::FieldTrial::Probability GetProbabilityForExperiment(
70 const std::string& experiment_name) override; 70 const std::string& experiment_name) const override;
71 bool IsPasswordSyncEnabled( 71 bool IsPasswordSyncEnabled(
72 password_manager::CustomPassphraseState state) override; 72 password_manager::CustomPassphraseState state) const override;
73 void OnLogRouterAvailabilityChanged(bool router_can_be_used) override; 73 void OnLogRouterAvailabilityChanged(bool router_can_be_used) override;
74 void LogSavePasswordProgress(const std::string& text) const override; 74 void LogSavePasswordProgress(const std::string& text) const override;
75 bool IsLoggingActive() const override; 75 bool IsLoggingActive() const override;
76 bool WasLastNavigationHTTPError() const override; 76 bool WasLastNavigationHTTPError() const override;
77 bool DidLastPageLoadEncounterSSLErrors() override; 77 bool DidLastPageLoadEncounterSSLErrors() const override;
78 bool IsOffTheRecord() override; 78 bool IsOffTheRecord() const override;
79 password_manager::PasswordManager* GetPasswordManager() override; 79 password_manager::PasswordManager* GetPasswordManager() override;
80 autofill::AutofillManager* GetAutofillManagerForMainFrame() override; 80 autofill::AutofillManager* GetAutofillManagerForMainFrame() override;
81 const GURL& GetMainFrameURL() override; 81 const GURL& GetMainFrameURL() const override;
82 82
83 // Hides any visible generation UI. 83 // Hides any visible generation UI.
84 void HidePasswordGenerationPopup(); 84 void HidePasswordGenerationPopup();
85 85
86 static void CreateForWebContentsWithAutofillClient( 86 static void CreateForWebContentsWithAutofillClient(
87 content::WebContents* contents, 87 content::WebContents* contents,
88 autofill::AutofillClient* autofill_client); 88 autofill::AutofillClient* autofill_client);
89 89
90 // Observer for PasswordGenerationPopup events. Used for testing. 90 // Observer for PasswordGenerationPopup events. Used for testing.
91 void SetTestObserver(autofill::PasswordGenerationPopupObserver* observer); 91 void SetTestObserver(autofill::PasswordGenerationPopupObserver* observer);
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 AutofillForSyncCredentialsState autofill_sync_state_; 170 AutofillForSyncCredentialsState autofill_sync_state_;
171 171
172 // If the sync credential was filtered during autofill. Used for statistics 172 // If the sync credential was filtered during autofill. Used for statistics
173 // reporting. 173 // reporting.
174 bool sync_credential_was_filtered_; 174 bool sync_credential_was_filtered_;
175 175
176 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 176 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
177 }; 177 };
178 178
179 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 179 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698