Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 691313003: Revert of Default geometry processor (Closed)

Created:
6 years, 1 month ago by joshualitt
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Default geometry processor (patchset #9 id:160001 of https://codereview.chromium.org/678953002/) Reason for revert: breaks nexus 5 Original issue's description: > Default geometry processor > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ff343074b2a3fdaa5f120600e28717e366bceadd TBR=bsalomon@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ee0ea3f0dd878fb5c8354924c0c8627ab2a95c41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+482 lines, -464 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/GrGeometryProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrAARectRenderer.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 2 chunks +394 lines, -0 lines 0 comments Download
D src/gpu/GrDefaultGeoProcFactory.h View 1 chunk +0 lines, -83 lines 0 comments Download
D src/gpu/GrDefaultGeoProcFactory.cpp View 1 chunk +0 lines, -182 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 4 chunks +4 lines, -20 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 8 chunks +36 lines, -60 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 3 chunks +3 lines, -14 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 4 chunks +20 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Default geometry processor
6 years, 1 month ago (2014-11-07 20:06:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691313003/1
6 years, 1 month ago (2014-11-07 20:07:31 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 20:08:07 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee0ea3f0dd878fb5c8354924c0c8627ab2a95c41

Powered by Google App Engine
This is Rietveld 408576698