Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

snapshot: Make destructors of interface classes public and virtual. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4ee00568b72e2aa25c262f2d46aacca36bddcffb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -28 lines) Patch
M snapshot/exception_snapshot.h View 2 chunks +2 lines, -3 lines 0 comments Download
M snapshot/mac/exception_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/memory_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/module_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/process_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/system_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/mac/thread_snapshot_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/memory_snapshot.h View 3 chunks +4 lines, -6 lines 0 comments Download
M snapshot/module_snapshot.h View 2 chunks +2 lines, -3 lines 0 comments Download
M snapshot/process_snapshot.h View 2 chunks +2 lines, -3 lines 0 comments Download
M snapshot/system_snapshot.h View 2 chunks +2 lines, -3 lines 0 comments Download
M snapshot/test/test_module_snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M snapshot/thread_snapshot.h View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
You’re going to like this one a lot. I wanted the TestSnapshot* family to work ...
6 years, 1 month ago (2014-10-29 17:46:12 UTC) #2
Robert Sesek
LGTM
6 years, 1 month ago (2014-10-29 20:53:12 UTC) #3
Mark Mentovai
6 years, 1 month ago (2014-10-29 21:31:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4ee00568b72e2aa25c262f2d46aacca36bddcffb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698