Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: snapshot/module_snapshot.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/memory_snapshot.h ('k') | snapshot/process_snapshot.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 12 matching lines...) Expand all
23 #include <vector> 23 #include <vector>
24 24
25 #include "util/misc/uuid.h" 25 #include "util/misc/uuid.h"
26 26
27 namespace crashpad { 27 namespace crashpad {
28 28
29 //! \brief An abstract interface to a snapshot representing a code module 29 //! \brief An abstract interface to a snapshot representing a code module
30 //! (binary image) loaded into a snapshot process. 30 //! (binary image) loaded into a snapshot process.
31 class ModuleSnapshot { 31 class ModuleSnapshot {
32 public: 32 public:
33 virtual ~ModuleSnapshot() {}
34
33 //! \brief A module’s type. 35 //! \brief A module’s type.
34 enum ModuleType { 36 enum ModuleType {
35 //! \brief The module’s type is unknown. 37 //! \brief The module’s type is unknown.
36 kModuleTypeUnknown = 0, 38 kModuleTypeUnknown = 0,
37 39
38 //! \brief The module is a main executable. 40 //! \brief The module is a main executable.
39 kModuleTypeExecutable, 41 kModuleTypeExecutable,
40 42
41 //! \brief The module is a shared library. 43 //! \brief The module is a shared library.
42 //! 44 //!
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 //! keys and values are strings. These are referred to in Chrome as “crash 140 //! keys and values are strings. These are referred to in Chrome as “crash
139 //! keys.” 141 //! keys.”
140 //! 142 //!
141 //! For Mac OS X snapshots, these annotations are found by interpreting the 143 //! For Mac OS X snapshots, these annotations are found by interpreting the
142 //! `__DATA, __crashpad_info` section as `CrashpadInfo`. Clients can use the 144 //! `__DATA, __crashpad_info` section as `CrashpadInfo`. Clients can use the
143 //! Crashpad client interface to store annotations in this structure. 145 //! Crashpad client interface to store annotations in this structure.
144 //! 146 //!
145 //! The annotations returned by this method do not duplicate those returned by 147 //! The annotations returned by this method do not duplicate those returned by
146 //! AnnotationsVector(). 148 //! AnnotationsVector().
147 virtual std::map<std::string, std::string> AnnotationsSimpleMap() const = 0; 149 virtual std::map<std::string, std::string> AnnotationsSimpleMap() const = 0;
148
149 protected:
150 ~ModuleSnapshot() {}
151 }; 150 };
152 151
153 } // namespace crashpad 152 } // namespace crashpad
154 153
155 #endif // CRASHPAD_SNAPSHOT_MODULE_SNAPSHOT_H_ 154 #endif // CRASHPAD_SNAPSHOT_MODULE_SNAPSHOT_H_
OLDNEW
« no previous file with comments | « snapshot/memory_snapshot.h ('k') | snapshot/process_snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698