Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: snapshot/system_snapshot.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/process_snapshot.h ('k') | snapshot/test/test_module_snapshot.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 11 matching lines...) Expand all
22 22
23 #include "snapshot/cpu_architecture.h" 23 #include "snapshot/cpu_architecture.h"
24 24
25 namespace crashpad { 25 namespace crashpad {
26 26
27 //! \brief An abstract interface to a snapshot representing the state of a 27 //! \brief An abstract interface to a snapshot representing the state of a
28 //! system, comprising an operating system, CPU architecture, and various 28 //! system, comprising an operating system, CPU architecture, and various
29 //! other characteristics. 29 //! other characteristics.
30 class SystemSnapshot { 30 class SystemSnapshot {
31 public: 31 public:
32 virtual ~SystemSnapshot() {}
33
32 //! \brief A system’s operating system family. 34 //! \brief A system’s operating system family.
33 enum OperatingSystem { 35 enum OperatingSystem {
34 //! \brief The snapshot system’s operating system is unknown. 36 //! \brief The snapshot system’s operating system is unknown.
35 kOperatingSystemUnknown = 0, 37 kOperatingSystemUnknown = 0,
36 38
37 //! \brief Mac OS X. 39 //! \brief Mac OS X.
38 kOperatingSystemMacOSX, 40 kOperatingSystemMacOSX,
39 }; 41 };
40 42
41 //! \brief A system’s daylight saving time status. 43 //! \brief A system’s daylight saving time status.
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 //! time. 250 //! time.
249 //! \param[out] standard_name The name of the time zone while standard time is 251 //! \param[out] standard_name The name of the time zone while standard time is
250 //! being observed. 252 //! being observed.
251 //! \param[out] daylight_name The name of the time zone while daylight saving 253 //! \param[out] daylight_name The name of the time zone while daylight saving
252 //! time is being observed. 254 //! time is being observed.
253 virtual void TimeZone(DaylightSavingTimeStatus* observes_daylight, 255 virtual void TimeZone(DaylightSavingTimeStatus* observes_daylight,
254 int* standard_offset_seconds, 256 int* standard_offset_seconds,
255 int* daylight_offset_seconds, 257 int* daylight_offset_seconds,
256 std::string* standard_name, 258 std::string* standard_name,
257 std::string* daylight_name) const = 0; 259 std::string* daylight_name) const = 0;
258
259 protected:
260 ~SystemSnapshot() {}
261 }; 260 };
262 261
263 } // namespace crashpad 262 } // namespace crashpad
264 263
265 #endif // CRASHPAD_SNAPSHOT_SYSTEM_SNAPSHOT_H_ 264 #endif // CRASHPAD_SNAPSHOT_SYSTEM_SNAPSHOT_H_
OLDNEW
« no previous file with comments | « snapshot/process_snapshot.h ('k') | snapshot/test/test_module_snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698