Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: snapshot/thread_snapshot.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/test/test_module_snapshot.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/thread_snapshot.h
diff --git a/snapshot/thread_snapshot.h b/snapshot/thread_snapshot.h
index 5203c2a04b0ce9dbcd76f472e8eb13013637bcd1..7ae883148f75f5db6bfd7c29aef1bcddf06dc38f 100644
--- a/snapshot/thread_snapshot.h
+++ b/snapshot/thread_snapshot.h
@@ -26,6 +26,8 @@ class MemorySnapshot;
//! (lightweight process) present in a snapshot process.
class ThreadSnapshot {
public:
+ virtual ~ThreadSnapshot() {}
+
//! \brief Returns a CPUContext object corresponding to the thread’s CPU
//! context.
//!
@@ -59,9 +61,6 @@ class ThreadSnapshot {
//! \brief Returns the base address of a region used to store thread-specific
//! data.
virtual uint64_t ThreadSpecificDataAddress() const = 0;
-
- protected:
- ~ThreadSnapshot() {}
};
} // namespace crashpad
« no previous file with comments | « snapshot/test/test_module_snapshot.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698