Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: snapshot/mac/memory_snapshot_mac.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/mac/exception_snapshot_mac.h ('k') | snapshot/mac/module_snapshot_mac.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 13 matching lines...) Expand all
24 #include "util/misc/initialization_state_dcheck.h" 24 #include "util/misc/initialization_state_dcheck.h"
25 25
26 namespace crashpad { 26 namespace crashpad {
27 namespace internal { 27 namespace internal {
28 28
29 //! \brief A MemorySnapshot of a memory region in a process on the running 29 //! \brief A MemorySnapshot of a memory region in a process on the running
30 //! system, when the system runs Mac OS X. 30 //! system, when the system runs Mac OS X.
31 class MemorySnapshotMac final : public MemorySnapshot { 31 class MemorySnapshotMac final : public MemorySnapshot {
32 public: 32 public:
33 MemorySnapshotMac(); 33 MemorySnapshotMac();
34 ~MemorySnapshotMac(); 34 ~MemorySnapshotMac() override;
35 35
36 //! \brief Initializes the object. 36 //! \brief Initializes the object.
37 //! 37 //!
38 //! Memory is read lazily. No attempt is made to read the memory snapshot data 38 //! Memory is read lazily. No attempt is made to read the memory snapshot data
39 //! until Read() is called, and the memory snapshot data is discared when 39 //! until Read() is called, and the memory snapshot data is discared when
40 //! Read() returns. 40 //! Read() returns.
41 //! 41 //!
42 //! \param[in] process_reader A reader for the process being snapshotted. 42 //! \param[in] process_reader A reader for the process being snapshotted.
43 //! \param[in] address The base address of the memory region to snapshot, in 43 //! \param[in] address The base address of the memory region to snapshot, in
44 //! the snapshot process’ address space. 44 //! the snapshot process’ address space.
(...skipping 14 matching lines...) Expand all
59 uint64_t size_; 59 uint64_t size_;
60 InitializationStateDcheck initialized_; 60 InitializationStateDcheck initialized_;
61 61
62 DISALLOW_COPY_AND_ASSIGN(MemorySnapshotMac); 62 DISALLOW_COPY_AND_ASSIGN(MemorySnapshotMac);
63 }; 63 };
64 64
65 } // namespace internal 65 } // namespace internal
66 } // namespace crashpad 66 } // namespace crashpad
67 67
68 #endif // CRASHPAD_SNAPSHOT_MAC_MEMORY_SNAPSHOT_MAC_H_ 68 #endif // CRASHPAD_SNAPSHOT_MAC_MEMORY_SNAPSHOT_MAC_H_
OLDNEW
« no previous file with comments | « snapshot/mac/exception_snapshot_mac.h ('k') | snapshot/mac/module_snapshot_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698