Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: snapshot/module_snapshot.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/memory_snapshot.h ('k') | snapshot/process_snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/module_snapshot.h
diff --git a/snapshot/module_snapshot.h b/snapshot/module_snapshot.h
index b7e2770782ce128de5b5a988e5b3164cb2455438..ef2a9c1f0c485d8b6f9b8004fb7233f05662c4ca 100644
--- a/snapshot/module_snapshot.h
+++ b/snapshot/module_snapshot.h
@@ -30,6 +30,8 @@ namespace crashpad {
//! (binary image) loaded into a snapshot process.
class ModuleSnapshot {
public:
+ virtual ~ModuleSnapshot() {}
+
//! \brief A module’s type.
enum ModuleType {
//! \brief The module’s type is unknown.
@@ -145,9 +147,6 @@ class ModuleSnapshot {
//! The annotations returned by this method do not duplicate those returned by
//! AnnotationsVector().
virtual std::map<std::string, std::string> AnnotationsSimpleMap() const = 0;
-
- protected:
- ~ModuleSnapshot() {}
};
} // namespace crashpad
« no previous file with comments | « snapshot/memory_snapshot.h ('k') | snapshot/process_snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698