Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: snapshot/exception_snapshot.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | snapshot/mac/exception_snapshot_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/exception_snapshot.h
diff --git a/snapshot/exception_snapshot.h b/snapshot/exception_snapshot.h
index 5788468a48aeadf9836f6a349343c9c320669a5e..20598332bcfd189d4cf6a197b84425b8f6dd49c9 100644
--- a/snapshot/exception_snapshot.h
+++ b/snapshot/exception_snapshot.h
@@ -27,6 +27,8 @@ struct CPUContext;
//! snapshot process sustained and triggered the snapshot being taken.
class ExceptionSnapshot {
public:
+ virtual ~ExceptionSnapshot() {}
+
//! \brief Returns a CPUContext object corresponding to the exception thread’s
//! CPU context at the time of the exception.
//!
@@ -86,9 +88,6 @@ class ExceptionSnapshot {
//! and the values of `code[0]` and `code[1]` as received by a Mach exception
//! handler.
virtual const std::vector<uint64_t>& Codes() const = 0;
-
- protected:
- ~ExceptionSnapshot() {}
};
} // namespace crashpad
« no previous file with comments | « no previous file | snapshot/mac/exception_snapshot_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698