Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1540)

Side by Side Diff: snapshot/mac/module_snapshot_mac.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/mac/memory_snapshot_mac.h ('k') | snapshot/mac/process_snapshot_mac.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 21 matching lines...) Expand all
32 class MachOImageReader; 32 class MachOImageReader;
33 struct UUID; 33 struct UUID;
34 34
35 namespace internal { 35 namespace internal {
36 36
37 //! \brief A ModuleSnapshot of a code module (binary image) loaded into a 37 //! \brief A ModuleSnapshot of a code module (binary image) loaded into a
38 //! running (or crashed) process on a Mac OS X system. 38 //! running (or crashed) process on a Mac OS X system.
39 class ModuleSnapshotMac final : public ModuleSnapshot { 39 class ModuleSnapshotMac final : public ModuleSnapshot {
40 public: 40 public:
41 ModuleSnapshotMac(); 41 ModuleSnapshotMac();
42 ~ModuleSnapshotMac(); 42 ~ModuleSnapshotMac() override;
43 43
44 //! \brief Initializes the object. 44 //! \brief Initializes the object.
45 //! 45 //!
46 //! \param[in] process_reader A ProcessReader for the task containing the 46 //! \param[in] process_reader A ProcessReader for the task containing the
47 //! module. 47 //! module.
48 //! \param[in] process_reader_module The module within the ProcessReader for 48 //! \param[in] process_reader_module The module within the ProcessReader for
49 //! which the snapshot should be created. 49 //! which the snapshot should be created.
50 //! 50 //!
51 //! \return `true` if the snapshot could be created, `false` otherwise with 51 //! \return `true` if the snapshot could be created, `false` otherwise with
52 //! an appropriate message logged. 52 //! an appropriate message logged.
(...skipping 26 matching lines...) Expand all
79 ProcessReader* process_reader_; // weak 79 ProcessReader* process_reader_; // weak
80 InitializationStateDcheck initialized_; 80 InitializationStateDcheck initialized_;
81 81
82 DISALLOW_COPY_AND_ASSIGN(ModuleSnapshotMac); 82 DISALLOW_COPY_AND_ASSIGN(ModuleSnapshotMac);
83 }; 83 };
84 84
85 } // namespace internal 85 } // namespace internal
86 } // namespace crashpad 86 } // namespace crashpad
87 87
88 #endif // CRASHPAD_SNAPSHOT_MAC_MODULE_SNAPSHOT_MAC_H_ 88 #endif // CRASHPAD_SNAPSHOT_MAC_MODULE_SNAPSHOT_MAC_H_
OLDNEW
« no previous file with comments | « snapshot/mac/memory_snapshot_mac.h ('k') | snapshot/mac/process_snapshot_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698