Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: snapshot/mac/system_snapshot_mac.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/mac/process_snapshot_mac.h ('k') | snapshot/mac/thread_snapshot_mac.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 16 matching lines...) Expand all
27 27
28 class ProcessReader; 28 class ProcessReader;
29 29
30 namespace internal { 30 namespace internal {
31 31
32 //! \brief A SystemSnapshot of the running system, when the system runs Mac OS 32 //! \brief A SystemSnapshot of the running system, when the system runs Mac OS
33 //! X. 33 //! X.
34 class SystemSnapshotMac final : public SystemSnapshot { 34 class SystemSnapshotMac final : public SystemSnapshot {
35 public: 35 public:
36 SystemSnapshotMac(); 36 SystemSnapshotMac();
37 ~SystemSnapshotMac(); 37 ~SystemSnapshotMac() override;
38 38
39 //! \brief Initializes the object. 39 //! \brief Initializes the object.
40 //! 40 //!
41 //! \param[in] process_reader A reader for the process being snapshotted. 41 //! \param[in] process_reader A reader for the process being snapshotted.
42 //! \n\n 42 //! \n\n
43 //! It seems odd that a system snapshot implementation would need a 43 //! It seems odd that a system snapshot implementation would need a
44 //! ProcessReader, but some of the information reported about the system 44 //! ProcessReader, but some of the information reported about the system
45 //! depends on the process it’s being reported for. For example, the 45 //! depends on the process it’s being reported for. For example, the
46 //! architecture returned by GetCPUArchitecture() should be the 46 //! architecture returned by GetCPUArchitecture() should be the
47 //! architecture of the process, which may be different than the native 47 //! architecture of the process, which may be different than the native
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 bool os_server_; 92 bool os_server_;
93 InitializationStateDcheck initialized_; 93 InitializationStateDcheck initialized_;
94 94
95 DISALLOW_COPY_AND_ASSIGN(SystemSnapshotMac); 95 DISALLOW_COPY_AND_ASSIGN(SystemSnapshotMac);
96 }; 96 };
97 97
98 } // namespace internal 98 } // namespace internal
99 } // namespace crashpad 99 } // namespace crashpad
100 100
101 #endif // CRASHPAD_SNAPSHOT_MAC_SYSTEM_SNAPSHOT_MAC_H_ 101 #endif // CRASHPAD_SNAPSHOT_MAC_SYSTEM_SNAPSHOT_MAC_H_
OLDNEW
« no previous file with comments | « snapshot/mac/process_snapshot_mac.h ('k') | snapshot/mac/thread_snapshot_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698