snapshot/test/test_module_snapshot.h - Issue 689483003: snapshot: Make destructors of interface classes public and virtual

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/test/test_module_snapshot.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/test/test_module_snapshot.h

diff --git a/snapshot/test/test_module_snapshot.h b/snapshot/test/test_module_snapshot.h

index fdaabca5aab7e17291cd9ca769aeac7d57ac9132..7aa5df3fd55d0b38f4d1fe192af021198b98e288 100644

--- a/snapshot/test/test_module_snapshot.h

+++ b/snapshot/test/test_module_snapshot.h

@@ -33,7 +33,7 @@ namespace test {

class TestModuleSnapshot final : public ModuleSnapshot {

public:

TestModuleSnapshot();

- ~TestModuleSnapshot();

+ ~TestModuleSnapshot() override;

void SetName(const std::string& name) { name_ = name; }

void SetAddressAndSize(uint64_t address, uint64_t size) {

« no previous file with comments | « snapshot/system_snapshot.h ('k') | snapshot/thread_snapshot.h » ('j') | no next file with comments »