Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: snapshot/process_snapshot.h

Issue 689483003: snapshot: Make destructors of interface classes public and virtual (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/module_snapshot.h ('k') | snapshot/system_snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/process_snapshot.h
diff --git a/snapshot/process_snapshot.h b/snapshot/process_snapshot.h
index 5138f83bc96eb1b9ac0a18de548b0cbfb779d90d..3fe317fa1f5517b082ccdabeb0a819833412d429 100644
--- a/snapshot/process_snapshot.h
+++ b/snapshot/process_snapshot.h
@@ -38,6 +38,8 @@ class ThreadSnapshot;
//! objects corresponding to thread stacks.
class ProcessSnapshot {
public:
+ virtual ~ProcessSnapshot() {}
+
//! \brief Returns the snapshot process’ process ID.
virtual pid_t ProcessID() const = 0;
@@ -106,9 +108,6 @@ class ProcessSnapshot {
//! object that it was obtained from. If the snapshot is not a result of
//! an exception, returns `nullptr`.
virtual const ExceptionSnapshot* Exception() const = 0;
-
- protected:
- ~ProcessSnapshot() {}
};
} // namespace crashpad
« no previous file with comments | « snapshot/module_snapshot.h ('k') | snapshot/system_snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698